Delete some unused code found by -Wunused-function

remoting/jingle_glue/xmpp_signal_strategy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/jingle_glue/xmpp_signal_strategy.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 #include "base/string_util.h"
 #include "base/thread_task_runner_handle.h"
 #include "jingle/glue/chrome_async_socket.h"
 #include "jingle/glue/task_pump.h"
 #include "jingle/glue/xmpp_client_socket_factory.h"
 #include "jingle/notifier/base/gaia_constants.h"
 #include "jingle/notifier/base/gaia_token_pre_xmpp_auth.h"
 #include "net/socket/client_socket_factory.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "third_party/libjingle/source/talk/base/thread.h"
 #include "third_party/libjingle/source/talk/xmpp/prexmppauth.h"
 #include "third_party/libjingle/source/talk/xmpp/saslcookiemechanism.h"
 
-namespace {
-
 const char kDefaultResourceName[] = "chromoting";
 
 // Use 58 seconds keep-alive interval, in case routers terminate
 // connections that are idle for more than a minute.
 const int kKeepAliveIntervalSeconds = 50;
 
 // Read buffer size used by ChromeAsyncSocket for read and write buffers. Most
 // of XMPP messages are smaller than 4kB.
 const size_t kReadBufferSize = 4096;
 const size_t kWriteBufferSize = 4096;
 
-void DisconnectXmppClient(buzz::XmppClient* client) {
-  client->Disconnect();
-}
-
-}  // namespace

[Wez, 2012/09/28 17:56:50]

We want these constants to be static, so we don't want to lose this namespace.

[Nico, 2012/09/28 17:59:37]

const has implicit static linkage. the namespace is not necessary.

-
 namespace remoting {
 
 XmppSignalStrategy::XmppSignalStrategy(
     scoped_refptr<net::URLRequestContextGetter> request_context_getter,
     const std::string& username,
     const std::string& auth_token,
     const std::string& auth_token_service)
    : request_context_getter_(request_context_getter),
      username_(username),
      auth_token_(auth_token),
@@ skipping 190 matching lines @@
   std::string mechanism = notifier::kDefaultGaiaAuthMechanism;
   if (settings.token_service() == "oauth2") {
     mechanism = "X-OAUTH2";
   }
 
   return new notifier::GaiaTokenPreXmppAuth(
       jid.Str(), settings.auth_token(), settings.token_service(), mechanism);
 }
 
 }  // namespace remoting