Revert 158940 - Adapt python scripts to use the new Forwarder2

Revert 158940 - Adapt python scripts to use the new Forwarder2

This is a DRAFT change.
I will polish it after running all the tests.
It worked for the integration tests.

BUG=


Review URL: https://chromiumcodereview.appspot.com/10957052

TBR=felipeg@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158960

[bulach_, 2012-09-27 10:23:36]

Isaac, sorry if I missed something but I can't see *any* information on
email or irc on why this patch has been reverted.

Has there been any communication about it? More important, what was the
cause?

As I was one of the reviewers and I'm paying close attention on this patch
trickling down to other trees, I'd like to understand what actions should I
take...

Please, whenever you revert any patch, provide as much information as
possible so that other people can understand and take appropriate
actions... I'm sure you have good reasons for doing so, but as it stands, I
have absolutely no visibility on why this has been done, and it'll
certainly impact the careful work felipe is doing in bringing this up in
both trees.

Again, apologies if I missed any communication, I was expecting to see a
bug / comment in this patch.

Thanks,
Marcus


On Thu, Sep 27, 2012 at 2:38 AM, <ilevy@chromium.org> wrote:

> Reviewers: felipeg1,
>
> Description:
> Revert 158940 - Adapt python scripts to use the new Forwarder2
>
> This is a DRAFT change.
> I will polish it after running all the tests.
> It worked for the integration tests.
>
> BUG=
>
>
> Review URL:
https://chromiumcodereview.**appspot.com/10957052<https://chromiumcodereview....
>
> TBR=felipeg@chromium.org
>
> Please review this at
https://codereview.chromium.**org/10977050/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   M     build/android/pylib/base_test_**runner.py
>   M     build/android/pylib/forwarder.**py
>   M     build/android/pylib/run_java_**tests.py
>   M     tools/android/forwarder2/host_**controller.cc
>   M     tools/android/forwarder2/**socket.cc
>
>
>

[Isaac (away), 2012-09-27 16:09:39]

(x-post from offline email thread)

Sorry -- will be more clear next time.  This was by request of Felipe (CL
author) who doesn't have SVN access.  I don't have a lot of details about the
problem, I know when we enabled it as our default forwarder downstream it broke
tests.

[felipeg_google, 2012-09-27 17:44:59]

Thanks a lot Isaac.

FYOI: After cherrypicking downstream I found out that the Smoke tests where
failing when sharding .
There is something wrong on how I am handling sharding in the python scripts
I did not have enough time to investigate.
I should get back to it today or tomorrow.



On Thu, Sep 27, 2012 at 9:09 AM, <ilevy@chromium.org> wrote:

> (x-post from offline email thread)
>
> Sorry -- will be more clear next time.  This was by request of Felipe (CL
> author) who doesn't have SVN access.  I don't have a lot of details about
> the
> problem, I know when we enabled it as our default forwarder downstream it
> broke
> tests.
>
>
https://codereview.chromium.**org/10977050/<https://codereview.chromium.org/1...
>