chrome/browser/extensions/extension_service.cc - Issue 10977048: Fix bug in disabling sync for default apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 10977048: Fix bug in disabling sync for default apps (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Addresed comments and fixed bugs. Removed not required from_webstore arguement Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 8c20453d0c69bd06cadbeb5aaa29e20b743c86fc..64477168e449b72084271eb66587678c745a8c76 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -2131,7 +2131,6 @@ void ExtensionService::UpdateActiveExtensionsInCrashReporter() {

void ExtensionService::OnExtensionInstalled(

const Extension* extension,

- bool from_webstore,

const syncer::StringOrdinal& page_ordinal,

bool has_requirement_errors) {

CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

@@ -2211,7 +2210,6 @@ void ExtensionService::OnExtensionInstalled(

extension_prefs_->OnExtensionInstalled(

extension,

initial_enable ? Extension::ENABLED : Extension::DISABLED,

- from_webstore,

page_ordinal);

// Unpacked extensions default to allowing file access, but if that has been