Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 1097703002: Wrap JSON and generator implementation in functions. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Wrap JSON and generator implementation in functions. R=jkummerow@chromium.org Committed: https://crrev.com/1df70e27491d00a818d23793a6cf63b7e326305b Cr-Commit-Position: refs/heads/master@{#27918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -60 lines) Patch
M src/generator.js View 4 chunks +37 lines, -36 lines 0 comments Download
M src/json.js View 8 chunks +21 lines, -22 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 8 months ago (2015-04-17 11:59:24 UTC) #1
Jakob Kummerow
lgtm
5 years, 8 months ago (2015-04-17 13:41:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097703002/1
5 years, 8 months ago (2015-04-17 13:43:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 13:53:21 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 13:53:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1df70e27491d00a818d23793a6cf63b7e326305b
Cr-Commit-Position: refs/heads/master@{#27918}

Powered by Google App Engine
This is Rietveld 408576698