Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 109763007: Reland r159735 - support for test harness (text-only) tests w/o expected results. (Closed)

Created:
7 years ago by Dirk Pranke
Modified:
6 years, 11 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Reland r159735 - support for test harness (text-only) tests w/o expected results. We re-land the initial change so that we can support importing and running tests from the w3c without needing to generate and maintain -expected.txt baselines for them (though we do support such baselines). The change from the prior version is to add a header and a footer to the output in testharnessreport.js, so that we can reliably detect that this is a testharness-based test (and that we've outputted all the assertions we have). R=ojan@chromium.org BUG=268711 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163996

Patch Set 1 : #

Patch Set 2 : add a single updated baseline for an example of the new output #

Total comments: 1

Patch Set 3 : update testharness-based baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -165 lines) Patch
M LayoutTests/css3/device-adapt/opera/cascading-001-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/cascading-002-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/cascading-003-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/css3/device-adapt/opera/cascading-004-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/css3/device-adapt/opera/constrain-001-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/css3/device-adapt/opera/constrain-002-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-003-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-004-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/css3/device-adapt/opera/constrain-005-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/css3/device-adapt/opera/constrain-006-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-007-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-008-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-009-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-010-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-011-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-012-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-013-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-014-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-015-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-016-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/css3/device-adapt/opera/constrain-017-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-018-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-019-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/cssom-001-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/css3/device-adapt/opera/descriptor-values-001-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/css3/device-adapt/opera/descriptor-values-002-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-003-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-004-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-005-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-006-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/descriptor-values-007-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/orientation-001-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/css3/device-adapt/opera/orientation-002-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/syntax-001-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/syntax-002-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/syntax-003-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-at-rule-parsing-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-cssom-01-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-delete-rule-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-height-extend-to-zoom-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-invalid-values-001-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-min-width-extend-to-zoom-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-properties-validation-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-user-agent-style-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/css3/device-adapt/viewport-user-style-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/viewport-width-extend-to-zoom-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/cssom/cssimportrule-media-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/cssom/cssimportrule-nested-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/cssom/cssstyledeclaration-csstext-final-delimiter-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/cssom/cssvalue-comparison-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/cssom/stylesheetlist-01-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/fast/css/parsing-unexpected-eof-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/css/pseudo-escaped-parenthesis-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLAppletElement/hspace-vspace-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/NodeIterator/NodeIterator-basic-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/fast/dom/body-frameset-event-handlers-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
LayoutTests/fast/dom/cross-frame-accessor-throw-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/attribute-changed-callback-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/callback-context-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/fast/dom/custom/created-callback-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/default-prototype-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-constructor-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/document-register-svg-extends-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/element-names-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/entered-left-document-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/processing-stack-recursion-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-isolation-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/registration-context-sharing-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/custom/type-extensions-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
LayoutTests/fast/dom/global-event-handlers-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/partial-layout-block-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/partial-layout-non-overlay-scrollbars-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/partial-layout-overlay-scrollbars-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/window-event-handlers-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-constructor-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-hash-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-host-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-hostname-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-href-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-origin-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-password-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-pathname-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-port-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-protocol-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-search-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/domurl/url-username-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/files/file-reader-abort-in-last-progress-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/files/file-reader-readystate-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/fast/files/file-reader-result-twice-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/files/read-blob-as-array-buffer-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/select-value-null-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/harness/results.html View 1 chunk +5 lines, -1 line 0 comments Download
M LayoutTests/fast/html/imports/import-shared-remove-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/media/media-query-list-syntax-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
LayoutTests/fast/media/mq-append-delete-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/fast/media/mq-color-index-01-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/media/mq-color-index-02-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/media/mq-js-update-media-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
LayoutTests/fast/media/w3c/test_media_queries-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
LayoutTests/fast/regions/region-styling/webkit-region-error-recovery-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/regions/region-styling/webkit-region-syntax-space-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/regions/webkit-flow-parsing-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/crossOrigin-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLTrackElement/kind-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrack/addCue-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrack/constants-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrack/cues-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrack/kind-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrack/label-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrack/language-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrack/mode-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrack/oncuechange-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrack/removeCue-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackCue/endTime-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackCue/id-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackCue/onenter-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackCue/onexit-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackCue/startTime-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackCue/track-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackCueList/getter-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackCueList/length-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackList/getter-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackList/length-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackList/onaddtrack-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TrackEvent/constructor-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/TrackEvent/createEvent-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/VTTCue/align-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/VTTCue/getCueAsHTML-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/VTTCue/line-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/VTTCue/snapToLines-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/VTTCue/text-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/interfaces/VTTCue/vertical-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/track/track-element/cloneNode-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/track/track-element/src-clear-cues-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/tests/entities-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/tests/tags-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/tests/timestamps-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/tests/tree-building-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/text-track-cue-constructor-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/track/track-element-load-event-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/video-intrinsic-width-height-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/media/video-playing-and-pause-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/printing/page-rule-specificity-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/resources/testharnessreport.js View 2 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/web-animations-api/element-animate-list-of-keyframes-expected.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py View 1 chunk +33 lines, -4 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py View 1 chunk +2 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/models/test_failures.py View 3 chunks +9 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py View 1 chunk +3 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/test.py View 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
Please take a look ... this is the same patch as the earlier version, except ...
7 years ago (2013-12-17 01:23:59 UTC) #1
ojan
lgtm https://codereview.chromium.org/109763007/diff/40001/LayoutTests/fast/harness/results.html File LayoutTests/fast/harness/results.html (right): https://codereview.chromium.org/109763007/diff/40001/LayoutTests/fast/harness/results.html#newcode579 LayoutTests/fast/harness/results.html:579: if (testObject.is_testharness_test) { Nit: single-line if/else shouldn't have ...
7 years ago (2013-12-17 01:33:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/109763007/40001
7 years ago (2013-12-17 01:33:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/109763007/60001
7 years ago (2013-12-17 01:47:14 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-17 04:39:10 UTC) #5
Message was sent while issue was closed.
Change committed as 163996

Powered by Google App Engine
This is Rietveld 408576698