Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h

Issue 1097603003: Remove knowledge of USB devices from permission prompt implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h
diff --git a/chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h b/chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h
index 4a17f499c1541486fc866a6364eb8a5cc64f27d3..73e04f7bf5abaa1f86b79ac56a39edda562dd157 100644
--- a/chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h
+++ b/chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h
@@ -20,19 +20,15 @@ class WebContents;
// Displays an device permissions selector prompt as a modal sheet constrained
// to the window/tab displaying the given web contents.
class DevicePermissionsDialogController
- : public extensions::DevicePermissionsPrompt::Delegate,
- public extensions::DevicePermissionsPrompt::Prompt::Observer,
+ : public extensions::DevicePermissionsPrompt::Prompt::Observer,
public ConstrainedWindowMacDelegate {
public:
DevicePermissionsDialogController(
content::WebContents* web_contents,
- extensions::DevicePermissionsPrompt::Delegate* delegate,
scoped_refptr<extensions::DevicePermissionsPrompt::Prompt> prompt);
~DevicePermissionsDialogController() override;
- // extensions::DevicePermissionsPrompt::Delegate implementation.
- void OnUsbDevicesChosen(
- const std::vector<scoped_refptr<device::UsbDevice>>& devices) override;
+ void Dismissed();
// extensions::DevicePermissionsPrompt::Prompt::Observer implementation.
void OnDevicesChanged() override;
@@ -40,15 +36,7 @@ class DevicePermissionsDialogController
// ConstrainedWindowMacDelegate implementation.
void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override;
- ConstrainedWindowMac* constrained_window() const {
- return constrained_window_.get();
- }
- DevicePermissionsViewController* view_controller() const {
- return view_controller_;
- }
-
private:
- extensions::DevicePermissionsPrompt::Delegate* delegate_;
scoped_refptr<extensions::DevicePermissionsPrompt::Prompt> prompt_;
base::scoped_nsobject<DevicePermissionsViewController> view_controller_;
scoped_ptr<ConstrainedWindowMac> constrained_window_;

Powered by Google App Engine
This is Rietveld 408576698