Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1097603003: Remove knowledge of USB devices from permission prompt implementations. (Closed)

Created:
5 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove knowledge of USB devices from permission prompt implementations. This change hides all the details of USB device objects inside of the DevicePermissionsPrompt::Prompt object so that the Views and OS X implementations do not need to be modified when this prompting logic is extended to support HID devices as well. BUG=457899 Committed: https://crrev.com/99ad34756e26e13a5252556a2df57397d5d8e20e Cr-Commit-Position: refs/heads/master@{#325761}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Initialize delegate_ to nullptr. #

Messages

Total messages: 17 (6 generated)
Reilly Grant (use Gerrit)
Peter, please take a look at chrome/browser/ui/views. Avi, please take a look at chrome/browser/ui/cocoa.
5 years, 8 months ago (2015-04-16 22:51:16 UTC) #2
Avi (use Gerrit)
Cocoa lgtm
5 years, 8 months ago (2015-04-16 22:59:38 UTC) #3
Peter Kasting
c/b/ui/views LGTM
5 years, 8 months ago (2015-04-16 23:02:18 UTC) #4
Reilly Grant (use Gerrit)
Devlin, please take a look at extensions/browser/api.
5 years, 8 months ago (2015-04-16 23:06:41 UTC) #6
Devlin
lgtm https://codereview.chromium.org/1097603003/diff/1/extensions/browser/api/device_permissions_prompt.h File extensions/browser/api/device_permissions_prompt.h (right): https://codereview.chromium.org/1097603003/diff/1/extensions/browser/api/device_permissions_prompt.h#newcode109 extensions/browser/api/device_permissions_prompt.h:109: Delegate* delegate_; init to null?
5 years, 8 months ago (2015-04-17 19:39:25 UTC) #7
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1097603003/diff/1/extensions/browser/api/device_permissions_prompt.h File extensions/browser/api/device_permissions_prompt.h (right): https://codereview.chromium.org/1097603003/diff/1/extensions/browser/api/device_permissions_prompt.h#newcode109 extensions/browser/api/device_permissions_prompt.h:109: Delegate* delegate_; On 2015/04/17 19:39:25, Devlin wrote: > init ...
5 years, 8 months ago (2015-04-17 20:05:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097603003/20001
5 years, 8 months ago (2015-04-17 20:05:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/13369)
5 years, 8 months ago (2015-04-17 21:00:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097603003/20001
5 years, 8 months ago (2015-04-17 23:00:50 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-18 02:11:54 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-18 02:13:22 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99ad34756e26e13a5252556a2df57397d5d8e20e
Cr-Commit-Position: refs/heads/master@{#325761}

Powered by Google App Engine
This is Rietveld 408576698