Delete session cookies immediately after loading the cookie DB.

Delete session cookies immediately after loading the cookie DB.

Previously, the session cookies were deleted after all cookies were loaded into
memory. This allows for a race condition where new session cookies are inserted
into the database while the cookies are being loaded into memory, which causes
the new session cookies to also be deleted.

BUG=

Committed: https://crrev.com/ca924dcfb4f3c6b89e0c40898e42aec349b6b843
Cr-Commit-Position: refs/heads/master@{#326672}

[erikchen, 2015-04-16 21:58:28]

erikchen@chromium.org changed reviewers:
+ erikwright@chromium.org

[erikchen, 2015-04-16 21:58:29]

erikwright: Please review.

This CL depends on https://codereview.chromium.org/1083623003/.

[erikwright (departed), 2015-04-17 01:22:00]

LGTM

[erikwright (departed), 2015-04-17 01:22:44]

On 2015/04/17 01:22:00, erikwright wrote:
> LGTM

Actually, is it possible to add a regression test? Presumably with the previous
code, a session cookie for a domain would still be present when it first loaded,
even if restore was disabled. I assume this can be tested.

[erikchen, 2015-04-17 20:40:02]

Patchset #3 (id:40001) has been deleted

[erikchen, 2015-04-17 20:40:06]

Patchset #2 (id:20001) has been deleted

[erikchen, 2015-04-17 20:42:04]

Patchset #2 (id:60001) has been deleted

[erikchen, 2015-04-17 20:42:58]

erikwright: Add a unit test. PTAL

[erikwright (departed), 2015-04-17 20:48:10]

LGTM. I assume you confirmed the test fails before your change?

[erikchen, 2015-04-17 20:51:28]

On 2015/04/17 20:48:10, erikwright wrote:
> LGTM. I assume you confirmed the test fails before your change?

That is correct.

[erikchen, 2015-04-17 20:51:42]

On 2015/04/17 20:51:28, erikchen wrote:
> On 2015/04/17 20:48:10, erikwright wrote:
> > LGTM. I assume you confirmed the test fails before your change?
> 
> That is correct.

Otherwise it wouldn't be a very useful test. ^-^

[erikchen, 2015-04-17 20:51:46]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-04-17 20:53:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1097593002/80001

[commit-bot: I haz the power, 2015-04-17 21:45:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-17 21:45:17]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[erikchen, 2015-04-17 21:49:26]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-04-17 21:50:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1097593002/80001

[commit-bot: I haz the power, 2015-04-17 22:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-17 22:19:42]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[erikchen, 2015-04-20 18:02:13]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-04-20 18:02:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikwright@chromium.org
Link to the patchset: https://codereview.chromium.org/1097593002/#ps100001
(title: "Fix calls to constructor for base::Time().")

[commit-bot: I haz the power, 2015-04-20 18:03:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1097593002/100001

[commit-bot: I haz the power, 2015-04-20 22:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-20 22:31:20]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2015-04-23 16:15:37]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-04-23 16:16:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1097593002/100001

[commit-bot: I haz the power, 2015-04-23 17:51:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-23 17:51:46]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2015-04-23 18:06:14]

On 2015/04/23 17:51:46, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_asan_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Oh, duh. It's the unittest leaking the cookies.

[erikchen, 2015-04-23 21:29:02]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-04-23 21:29:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikwright@chromium.org
Link to the patchset: https://codereview.chromium.org/1097593002/#ps120001
(title: "Fix memory leak in unit test.")

[commit-bot: I haz the power, 2015-04-23 21:30:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1097593002/120001

[commit-bot: I haz the power, 2015-04-23 22:22:28]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2015-04-23 22:23:18]

Patchset 4 (id:??) landed as
https://crrev.com/ca924dcfb4f3c6b89e0c40898e42aec349b6b843
Cr-Commit-Position: refs/heads/master@{#326672}

[Justin Donnelly, 2015-04-23 23:56:21]

A revert of this CL (patchset #4 id:120001) has been created in
https://codereview.chromium.org/1077963006/ by jdonnelly@chromium.org.

The reason for reverting is: This CL broke the Win7 Tests (dbg)(1) bot.

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2....