Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1097573002: Re-enable draw_properties.tough_scrolling on Windows. (Closed)

Created:
5 years, 8 months ago by sullivan
Modified:
5 years, 8 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable draw_properties.tough_scrolling on Windows. I can't reproduce a MemoryError locally or on the try bots, and the original bug only shows MemoryErrors on the top_25 pageset. Successfult tryjobs: https://codereview.chromium.org/1086243002/ BUG=463111 Committed: https://crrev.com/bccb2925bf98bd56e69aeeb7b634aad617675759 Cr-Commit-Position: refs/heads/master@{#325539}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf/benchmarks/draw_properties.py View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
sullivan
5 years, 8 months ago (2015-04-16 21:27:00 UTC) #2
nednguyen
https://codereview.chromium.org/1097573002/diff/1/tools/perf/benchmarks/draw_properties.py File tools/perf/benchmarks/draw_properties.py (right): https://codereview.chromium.org/1097573002/diff/1/tools/perf/benchmarks/draw_properties.py#newcode12 tools/perf/benchmarks/draw_properties.py:12: @benchmark.Disabled('reference', # http://crbug.com/463111 Should we remove the "# http://crbug.com/463111"?
5 years, 8 months ago (2015-04-16 21:29:07 UTC) #3
sullivan
On 2015/04/16 21:29:07, nednguyen wrote: > https://codereview.chromium.org/1097573002/diff/1/tools/perf/benchmarks/draw_properties.py > File tools/perf/benchmarks/draw_properties.py (right): > > https://codereview.chromium.org/1097573002/diff/1/tools/perf/benchmarks/draw_properties.py#newcode12 > ...
5 years, 8 months ago (2015-04-16 21:33:06 UTC) #4
nednguyen
lgtm
5 years, 8 months ago (2015-04-16 21:36:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097573002/1
5 years, 8 months ago (2015-04-16 21:37:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 23:10:47 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 23:12:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bccb2925bf98bd56e69aeeb7b634aad617675759
Cr-Commit-Position: refs/heads/master@{#325539}

Powered by Google App Engine
This is Rietveld 408576698