Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1097563002: adding new gm to rotate, translate, and scale textblobs (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

adding new gm to rotate, translate, and scale textblobs this is to test distance field caching and regen of texture blobs on scale. BUG=skia: Committed: https://skia.googlesource.com/skia/+/523ed6c0c1ac9029be315542258e02ba9854365c

Patch Set 1 #

Total comments: 1

Patch Set 2 : small typo #

Patch Set 3 : windows warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -0 lines) Patch
A gm/textblobtransforms.cpp View 1 2 1 chunk +172 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
joshualitt
Jim, do you see any other cases which might be interesting. I did lots of ...
5 years, 8 months ago (2015-04-16 20:47:51 UTC) #3
joshualitt
adding Brian mostly for fyi
5 years, 8 months ago (2015-04-16 20:52:26 UTC) #5
jvanverth1
LGTM + comment https://codereview.chromium.org/1097563002/diff/1/gm/textblobtransforms.cpp File gm/textblobtransforms.cpp (right): https://codereview.chromium.org/1097563002/diff/1/gm/textblobtransforms.cpp#newcode27 gm/textblobtransforms.cpp:27: // make textblob. To stress distance ...
5 years, 8 months ago (2015-04-17 13:04:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097563002/20001
5 years, 8 months ago (2015-04-17 15:31:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/545)
5 years, 8 months ago (2015-04-17 15:46:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097563002/40001
5 years, 8 months ago (2015-04-17 15:55:11 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 16:01:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/523ed6c0c1ac9029be315542258e02ba9854365c

Powered by Google App Engine
This is Rietveld 408576698