Avoid drawing SVG image content when the image is of zero size.

Avoid drawing SVG image content when the image is of zero size.

R=pdr
BUG=330420
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164536

[pdr., 2014-01-06 18:24:02]

I like this at a high level but I think we can make this check a bit more
general.

https://codereview.chromium.org/109753004/diff/1/Source/core/rendering/svg/Re...
File Source/core/rendering/svg/RenderSVGImage.cpp (right):

https://codereview.chromium.org/109753004/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/RenderSVGImage.cpp:133: if
(!SVGRenderSupport::paintInfoIntersectsRepaintRect(boundingBox,
m_localTransform, paintInfo))
Can you move the bounding box empty check into this
paintInfoIntersectsRepaintRect function?

[Stephen Chennney, 2014-01-06 20:01:58]

On 2014/01/06 18:24:02, pdr wrote:
> I like this at a high level but I think we can make this check a bit more
> general.
> 
>
https://codereview.chromium.org/109753004/diff/1/Source/core/rendering/svg/Re...
> File Source/core/rendering/svg/RenderSVGImage.cpp (right):
> 
>
https://codereview.chromium.org/109753004/diff/1/Source/core/rendering/svg/Re...
> Source/core/rendering/svg/RenderSVGImage.cpp:133: if
> (!SVGRenderSupport::paintInfoIntersectsRepaintRect(boundingBox,
> m_localTransform, paintInfo))
> Can you move the bounding box empty check into this
> paintInfoIntersectsRepaintRect function?

I think we still need to draw the outline box if specified. So I do not want to
move the check.

[pdr., 2014-01-06 20:41:17]

On 2014/01/06 20:01:58, Stephen Chenney wrote:
> On 2014/01/06 18:24:02, pdr wrote:
> > I like this at a high level but I think we can make this check a bit more
> > general.
> > 
> >
>
https://codereview.chromium.org/109753004/diff/1/Source/core/rendering/svg/Re...
> > File Source/core/rendering/svg/RenderSVGImage.cpp (right):
> > 
> >
>
https://codereview.chromium.org/109753004/diff/1/Source/core/rendering/svg/Re...
> > Source/core/rendering/svg/RenderSVGImage.cpp:133: if
> > (!SVGRenderSupport::paintInfoIntersectsRepaintRect(boundingBox,
> > m_localTransform, paintInfo))
> > Can you move the bounding box empty check into this
> > paintInfoIntersectsRepaintRect function?
> 
> I think we still need to draw the outline box if specified. So I do not want
to
> move the check.

LGTM

[Stephen Chennney, 2014-01-06 21:14:11]

On 2014/01/06 20:41:17, pdr wrote:
> On 2014/01/06 20:01:58, Stephen Chenney wrote:
> > On 2014/01/06 18:24:02, pdr wrote:
> > > I like this at a high level but I think we can make this check a bit more
> > > general.
> > > 
> > >
> >
>
https://codereview.chromium.org/109753004/diff/1/Source/core/rendering/svg/Re...
> > > File Source/core/rendering/svg/RenderSVGImage.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/109753004/diff/1/Source/core/rendering/svg/Re...
> > > Source/core/rendering/svg/RenderSVGImage.cpp:133: if
> > > (!SVGRenderSupport::paintInfoIntersectsRepaintRect(boundingBox,
> > > m_localTransform, paintInfo))
> > > Can you move the bounding box empty check into this
> > > paintInfoIntersectsRepaintRect function?
> > 
> > I think we still need to draw the outline box if specified. So I do not want
> to
> > move the check.
> 
> LGTM

I'll file a bug for the case where we fail to draw the outline for mostly
off-screen elements due to the SVGRenderSupport method not considering the
outline (if indeed that is the case).

[commit-bot: I haz the power, 2014-01-06 21:14:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/schenney@chromium.org/109753004/1

[commit-bot: I haz the power, 2014-01-07 00:39:14]

Change committed as 164536