ozone: OZONE_NATIVE_BUFFER requires GL_TEXTURE_EXTERNAL_OES.

ozone: OZONE_NATIVE_BUFFER requires GL_TEXTURE_EXTERNAL_OES.

Ozone uses EGLImage backed GPU memory buffers via OES_EGL_image_external[1] extensions.
The texture target created from external EGLImage must be GL_TEXTURE_EXTERNAL_OES.

[1] https://www.khronos.org/registry/gles/extensions/OES/OES_EGL_image_external.txt

BUG=475633
Committed: https://crrev.com/d606a6ceb1bded7d1d0c9ea112322d7c9663ee21
Cr-Commit-Position: refs/heads/master@{#325780}

[dshwang, 2015-04-16 18:45:20]

dongseong.hwang@intel.com changed reviewers:
+ reveman@chromium.org, sievers@chromium.org

[dshwang, 2015-04-16 18:45:20]

It's extracted from https://codereview.chromium.org/1071273002 as reveman@
requested.

sievers@, could you review?

[no sievers, 2015-04-16 18:55:27]

lgtm

[reveman, 2015-04-16 19:39:20]

https://codereview.chromium.org/1097503003/diff/1/content/browser/gpu/browser...
File content/browser/gpu/browser_gpu_channel_host_factory.cc (right):

https://codereview.chromium.org/1097503003/diff/1/content/browser/gpu/browser...
content/browser/gpu/browser_gpu_channel_host_factory.cc:266: // EGLImage backed
GPU memory buffers require TEXTURE_EXTERNAL_OES.
nit: These buffers are not technically backed by EGLImages. EGLImages are just
used as a mechanism to share these buffers with the GL. Maybe "GPU memory
buffers that are shared with the GL using EGLImages require
TEXTURE_EXTERNAL_OES."

[dshwang, 2015-04-18 08:06:12]

On 2015/04/16 19:39:20, reveman wrote:
>
https://codereview.chromium.org/1097503003/diff/1/content/browser/gpu/browser...
> File content/browser/gpu/browser_gpu_channel_host_factory.cc (right):
> 
>
https://codereview.chromium.org/1097503003/diff/1/content/browser/gpu/browser...
> content/browser/gpu/browser_gpu_channel_host_factory.cc:266: // EGLImage
backed
> GPU memory buffers require TEXTURE_EXTERNAL_OES.
> nit: These buffers are not technically backed by EGLImages. EGLImages are just
> used as a mechanism to share these buffers with the GL. Maybe "GPU memory
> buffers that are shared with the GL using EGLImages require
> TEXTURE_EXTERNAL_OES."

Thank you for reviewing. done.

[dshwang, 2015-04-18 08:06:17]

The CQ bit was checked by dongseong.hwang@intel.com

[dshwang, 2015-04-18 08:06:18]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1097503003/#ps20001
(title: "improve comment")

[commit-bot: I haz the power, 2015-04-18 08:06:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1097503003/20001

[commit-bot: I haz the power, 2015-04-18 13:36:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-18 13:38:02]

Patchset 2 (id:??) landed as
https://crrev.com/d606a6ceb1bded7d1d0c9ea112322d7c9663ee21
Cr-Commit-Position: refs/heads/master@{#325780}