Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1097443004: Oilpan: rename GCState and GCReason values to reflect function only. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, oilpan-reviews, Mads Ager (chromium), vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, kouhei+heap_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: rename GCState and GCReason values to reflect function only. Rename ThreadState::GCScheduledForTesting to ThreadState::FullGCScheduled and Heap::ForcedGCForTesting to Heap::ForcedGC. That is, just reflect their purpose, and have the names no longer include the context where they're often, but not always, used (testing code to flush out garbage.) R=haraken BUG=478613 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -174 lines) Patch
M Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8GCController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/CrossThreadTaskTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/ImageBitmapTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/Heap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/Heap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 104 chunks +154 lines, -154 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/ThreadState.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/web/WebHeap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
5 years, 8 months ago (2015-04-20 15:21:05 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-20 15:23:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097443004/1
5 years, 8 months ago (2015-04-20 16:13:21 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 19:16:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194046

Powered by Google App Engine
This is Rietveld 408576698