Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1097423003: Disable the test isolation on the Android deterministic builder. (Closed)

Created:
5 years, 8 months ago by Sébastien Marchand
Modified:
5 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Disable the test isolation on the Android deterministic builder. test_isolation_mode!=noop is not supported on android so the compile fails. BUG=383340 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -74 lines) Patch
M scripts/slave/recipes/swarming/deterministic_build.py View 3 chunks +12 lines, -6 lines 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic_build.json View 4 chunks +2 lines, -68 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sébastien Marchand
PTAL.
5 years, 8 months ago (2015-04-21 22:46:08 UTC) #2
M-A Ruel
You should update the CL description to say why, e.g.: test_isolation_mode!=noop is not supported on ...
5 years, 8 months ago (2015-04-21 22:48:13 UTC) #3
M-A Ruel
lgtm
5 years, 8 months ago (2015-04-21 22:48:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097423003/1
5 years, 8 months ago (2015-04-21 22:49:51 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 22:53:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294932

Powered by Google App Engine
This is Rietveld 408576698