Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1097423002: Stop generating the [TOC] in the GN reference docs. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop generating the [TOC] in the GN reference docs. As doing so causes Gitiles to crash. Also, update the docs with the response file change to 'gn refs'. R=brettw@chromium.org BUG=468851 , https://code.google.com/p/gitiles/issues/detail?id=75 Committed: https://crrev.com/36a275daed9a044694646530ab58694b487bad4e Cr-Commit-Position: refs/heads/master@{#326176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M tools/gn/command_help.cc View 1 chunk +5 lines, -1 line 0 comments Download
M tools/gn/docs/reference.md View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097423002/1
5 years, 8 months ago (2015-04-21 21:20:36 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-21 22:06:09 UTC) #4
brettw
lgtm
5 years, 8 months ago (2015-04-21 23:43:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097423002/1
5 years, 8 months ago (2015-04-21 23:44:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 23:46:02 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 23:47:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36a275daed9a044694646530ab58694b487bad4e
Cr-Commit-Position: refs/heads/master@{#326176}

Powered by Google App Engine
This is Rietveld 408576698