Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 1097413004: Use a breakpoint instruction for a stop message on arm instead of (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm.h ('k') | runtime/vm/assembler_arm64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.cc
===================================================================
--- runtime/vm/assembler_arm.cc (revision 45360)
+++ runtime/vm/assembler_arm.cc (working copy)
@@ -1470,14 +1470,6 @@
}
-void Assembler::svc(uint32_t imm24, Condition cond) {
- ASSERT(cond != kNoCondition);
- ASSERT(imm24 < (1 << 24));
- int32_t encoding = (cond << kConditionShift) | B27 | B26 | B25 | B24 | imm24;
- Emit(encoding);
-}
-
-
void Assembler::bkpt(uint16_t imm16) {
// bkpt requires that the cond field is AL.
int32_t encoding = (AL << kConditionShift) | B24 | B21 |
@@ -3485,7 +3477,7 @@
b(&stop);
Emit(reinterpret_cast<int32_t>(message));
Bind(&stop);
- svc(kStopMessageSvcCode);
+ bkpt(Instr::kStopMessageCode);
}
« no previous file with comments | « runtime/vm/assembler_arm.h ('k') | runtime/vm/assembler_arm64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698