Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1097393002: Added Launcher_SwitchTask UMA user action. (Closed)

Created:
5 years, 8 months ago by bruthig
Modified:
5 years, 8 months ago
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added Launcher_SwitchTask UMA user action. The Launcher_SwitchTask user action records when a user activates an existing window using an icon in the shelf. TEST=ShelfViewTest.Launcher_ButtonPressedUserActionsRecordedWhenItemSelected TEST=ShelfViewTest.Launcher_TaskUserActionsRecordedWhenItemSelected TEST=ShelfViewTest.Launcher_ButtonPressed_MouseIsRecordedWhenIconActivatedByMouse TEST=ShelfViewTest.Launcher_ButtonPressed_MouseIsRecordedWhenIconActivatedByTouch TEST=ShelfViewTest.Launcher_LaunchTaskIsRecordedWhenNewWindowIsCreated TEST=ShelfViewTest.Launcher_SwitchTaskIsRecordedWhenExistingWindowIsActivated BUG=471354 Committed: https://crrev.com/bc37a675e8579e38807e83c2e5d8d16be61f8699 Cr-Commit-Position: refs/heads/master@{#326321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -32 lines) Patch
M ash/metrics/user_metrics_recorder.h View 3 chunks +4 lines, -3 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/shelf/shelf_view.h View 2 chunks +9 lines, -0 lines 0 comments Download
M ash/shelf/shelf_view.cc View 4 chunks +38 lines, -26 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 5 chunks +92 lines, -3 lines 0 comments Download
M ash/test/shelf_view_test_api.h View 2 chunks +9 lines, -0 lines 0 comments Download
M ash/test/shelf_view_test_api.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
bruthig
rkaplow@|asvitkine@: Please review changes in tools/metrics/* oshima@: Please review changes in ash/*
5 years, 8 months ago (2015-04-21 21:29:25 UTC) #2
oshima
ash lgtm
5 years, 8 months ago (2015-04-21 22:49:49 UTC) #3
rkaplow
lgtm
5 years, 8 months ago (2015-04-22 14:22:17 UTC) #4
Alexei Svitkine (slow)
lgtm
5 years, 8 months ago (2015-04-22 15:57:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097393002/1
5 years, 8 months ago (2015-04-22 16:00:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 17:08:22 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 17:11:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc37a675e8579e38807e83c2e5d8d16be61f8699
Cr-Commit-Position: refs/heads/master@{#326321}

Powered by Google App Engine
This is Rietveld 408576698