LayoutTests/http/tests/notifications/notification-sandbox-permission.html - Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/notifications/notification-sandbox-permission.html

Issue 1097383006: Notifications: use testRunner.setPermission() in addition of grantWebNotificationPermission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cleanup

Patch Set: fix expectations Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/close-shared-worker.html ('k') | LayoutTests/http/tests/notifications/permission-document.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <p>	4 <p>

5 Tests that the <iframe sandbox> attribute influences whether	5 Tests that the <iframe sandbox> attribute influences whether

6 notification permissions will be inherit by an iframe.	6 notification permissions will be inherit by an iframe.

7 </p>	7 </p>

8 <div id="console"></div>	8 <div id="console"></div>

9 <script>	9 <script>

10 if (window.testRunner) {	10 if (window.testRunner) {

	11 testRunner.setPermission('notifications', 'granted', location.or igin, location.origin);

11 testRunner.grantWebNotificationPermission(location.origin, true) ;	12 testRunner.grantWebNotificationPermission(location.origin, true) ;

12 testRunner.dumpAsText();	13 testRunner.dumpAsText();

13 testRunner.dumpChildFramesAsText();	14 testRunner.dumpChildFramesAsText();

14 }	15 }

15 </script>	16 </script>

16	17

17 <h1>Normal iframe. Should inherit permissions.</h1>	18 <h1>Normal iframe. Should inherit permissions.</h1>

18 <iframe src="resources/display-permission.html"></iframe>	19 <iframe src="resources/display-permission.html"></iframe>

19	20

20 <h1>Sandboxed iframe with allow-same-origin. Should inherit permissions. </h1>	21 <h1>Sandboxed iframe with allow-same-origin. Should inherit permissions. </h1>

21 <iframe src="resources/display-permission.html" sandbox="allow-scripts a llow-same-origin"></iframe>	22 <iframe src="resources/display-permission.html" sandbox="allow-scripts a llow-same-origin"></iframe>

22	23

23 <h1>Sandboxed iframe without allow-same-origin. Should not inherit permi ssions.</h1>	24 <h1>Sandboxed iframe without allow-same-origin. Should not inherit permi ssions.</h1>

24 <iframe src="resources/display-permission.html" sandbox="allow-scripts"> </iframe>	25 <iframe src="resources/display-permission.html" sandbox="allow-scripts"> </iframe>

25 </body>	26 </body>

26 </html>	27 </html>

OLD	NEW