chrome/browser/search/suggestions/image_fetcher_impl.cc - Issue 1097383005: Add possibility to define data callback to BitmapFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/suggestions/image_fetcher_impl.cc

Issue 1097383005: Add possibility to define data callback to BitmapFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r479598_extensions_content_verifier_directories_fail

Patch Set: Another approach - split Start to Init and Start Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bitmap_fetcher/bitmap_fetcher.h ('K') | « chrome/browser/profiles/profile_avatar_downloader.cc ('k') | chrome/browser/ui/passwords/account_avatar_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/suggestions/image_fetcher_impl.cc

diff --git a/chrome/browser/search/suggestions/image_fetcher_impl.cc b/chrome/browser/search/suggestions/image_fetcher_impl.cc

index 7607af9398bc2eacafe3da110131f1615e52f86f..0b2483607775a005d9e7f2163478f8b5659d3c09 100644

--- a/chrome/browser/search/suggestions/image_fetcher_impl.cc

+++ b/chrome/browser/search/suggestions/image_fetcher_impl.cc

@@ -42,10 +42,11 @@ void ImageFetcherImpl::StartOrQueueNetworkRequest(

ImageRequest request(new chrome::BitmapFetcher(image_url, this));

request.url = url;

request.callbacks.push_back(callback);

- request.fetcher->Start(

+ request.fetcher->Init(

url_request_context_, std::string(),

net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,

net::LOAD_NORMAL);

+ request.fetcher->Start();

pending_net_requests_[image_url].swap(&request);

} else {

// Request in progress. Register as an interested callback.