chrome/browser/extensions/api/webstore_private/webstore_private_api.cc - Issue 1097383005: Add possibility to define data callback to BitmapFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 1097383005: Add possibility to define data callback to BitmapFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r479598_extensions_content_verifier_directories_fail

Patch Set: Another approach - split Start to Init and Start Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bitmap_fetcher/bitmap_fetcher.h ('K') | « chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc ('k') | chrome/browser/extensions/webstore_install_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

index a3a58c760e47a6885f7644f2def8a4ff68f48872..f954179ba025222689235ab65416bf44cbbfdcfb 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

@@ -616,10 +616,11 @@ ExtensionFunction::ResponseAction WebstorePrivateInstallBundleFunction::Run() {

// The bitmap fetcher will call us back via OnFetchComplete.

icon_fetcher_.reset(new chrome::BitmapFetcher(icon_url, this));

- icon_fetcher_->Start(

+ icon_fetcher_->Init(

browser_context()->GetRequestContext(), std::string(),

net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,

net::LOAD_DO_NOT_SAVE_COOKIES | net::LOAD_DO_NOT_SEND_COOKIES);

+ icon_fetcher_->Start();

} else {

base::MessageLoopProxy::current()->PostTask(

FROM_HERE,