chrome/browser/extensions/webstore_install_helper.cc - Issue 1097383005: Add possibility to define data callback to BitmapFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_install_helper.cc

Issue 1097383005: Add possibility to define data callback to BitmapFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r479598_extensions_content_verifier_directories_fail

Patch Set: Clarified how calling Init/Start twice works + fixed android Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/webstore_install_helper.cc

diff --git a/chrome/browser/extensions/webstore_install_helper.cc b/chrome/browser/extensions/webstore_install_helper.cc

index 948d9954134fe6b38718be0cd34471830942c63a..a2654d00117d695522d1c79b9892c342abede754 100644

--- a/chrome/browser/extensions/webstore_install_helper.cc

+++ b/chrome/browser/extensions/webstore_install_helper.cc

@@ -58,10 +58,11 @@ void WebstoreInstallHelper::Start() {

CHECK(!icon_fetcher_.get());

AddRef(); // Balanced in OnFetchComplete().

icon_fetcher_.reset(new chrome::BitmapFetcher(icon_url_, this));

- icon_fetcher_->Start(

+ icon_fetcher_->Init(

context_getter_, std::string(),

net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,

net::LOAD_DO_NOT_SAVE_COOKIES | net::LOAD_DO_NOT_SEND_COOKIES);

+ icon_fetcher_->Start();

}

BrowserThread::PostTask(

« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper.cc ('k') | chrome/browser/image_holder.cc » ('j') | no next file with comments »