chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc - Issue 1097383005: Add possibility to define data callback to BitmapFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc

Issue 1097383005: Add possibility to define data callback to BitmapFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r479598_extensions_content_verifier_directories_fail

Patch Set: Clarified how calling Init/Start twice works + fixed android Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc ('k') | chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc

diff --git a/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc b/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc

index aef3ba651c2e5e713e09218082eb5421209adc84..5613993dc057282c03a9f8eddbff87af520b46d2 100644

--- a/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc

+++ b/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc

@@ -121,11 +121,12 @@ void BitmapFetcherService::Prefetch(const GURL& url) {

chrome::BitmapFetcher* BitmapFetcherService::CreateFetcher(const GURL& url) {

chrome::BitmapFetcher* new_fetcher = new chrome::BitmapFetcher(url, this);

- new_fetcher->Start(

+ new_fetcher->Init(

context_->GetRequestContext(),

std::string(),

net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,

net::LOAD_NORMAL);

+ new_fetcher->Start();

return new_fetcher;

}