Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: chrome/browser/bitmap_fetcher/bitmap_fetcher.h

Issue 1097383005: Add possibility to define data callback to BitmapFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r479598_extensions_content_verifier_directories_fail
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bitmap_fetcher/bitmap_fetcher.h
diff --git a/chrome/browser/bitmap_fetcher/bitmap_fetcher.h b/chrome/browser/bitmap_fetcher/bitmap_fetcher.h
index 11055eaf61a50e8aaf7a051e629858c5435e7de5..a68a1c9122f28faf002dfb66c6aa389b1dd444ed 100644
--- a/chrome/browser/bitmap_fetcher/bitmap_fetcher.h
+++ b/chrome/browser/bitmap_fetcher/bitmap_fetcher.h
@@ -8,13 +8,13 @@
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/bitmap_fetcher/bitmap_fetcher_delegate.h"
#include "chrome/browser/image_decoder.h"
+#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_fetcher_delegate.h"
#include "net/url_request/url_request.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "url/gurl.h"
namespace net {
-class URLFetcher;
class URLRequestContextGetter;
} // namespace net
@@ -41,6 +41,15 @@ class BitmapFetcher : public net::URLFetcherDelegate,
net::URLRequest::ReferrerPolicy referrer_policy,
int load_flags);
+ // Like BitmapFetcher::Start above but it allows to define user data key
+ // and create data callback for URLFetcher it creates.
Theresa 2015/04/22 23:07:06 The phrasing here is a little unclear, maybe somet
+ void Start(net::URLRequestContextGetter* request_context,
+ const std::string& referrer,
+ net::URLRequest::ReferrerPolicy referrer_policy,
+ int load_flags,
+ const void* user_data_key,
+ const net::URLFetcher::CreateDataCallback& create_data_callback);
+
// Methods inherited from URLFetcherDelegate
// This will be called when the URL has been fetched, successfully or not.
@@ -68,6 +77,12 @@ class BitmapFetcher : public net::URLFetcherDelegate,
// Alerts the delegate that a failure occurred.
void ReportFailure();
+ scoped_ptr<net::URLFetcher> CreateURLFetcher(
+ net::URLRequestContextGetter* request_context,
+ const std::string& referrer,
+ net::URLRequest::ReferrerPolicy referrer_policy,
+ int load_flags);
+
scoped_ptr<net::URLFetcher> url_fetcher_;
const GURL url_;
BitmapFetcherDelegate* const delegate_;
« no previous file with comments | « no previous file | chrome/browser/bitmap_fetcher/bitmap_fetcher.cc » ('j') | chrome/browser/bitmap_fetcher/bitmap_fetcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698