Add possibility to define data callback to BitmapFetcher

chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"
 
 #include "base/compiler_specific.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/test/base/in_process_browser_test.h"
@@ skipping 95 matching lines @@
   // Set up a delegate to wait for the callback.
   BitmapFetcherTestDelegate delegate(kAsyncCall);
 
   BitmapFetcher fetcher(url, &delegate);
 
   url_fetcher_factory_->SetFakeResponse(
       url, image_string, net::HTTP_OK, net::URLRequestStatus::SUCCESS);
 
   // We expect that the image decoder will get called and return
   // an image in a callback to OnImageDecoded().
-  fetcher.Start(
+  fetcher.Init(
       browser()->profile()->GetRequestContext(),
       std::string(),
       net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,
       net::LOAD_NORMAL);
+  fetcher.Start();
 
   // Blocks until test delegate is notified via a callback.
   delegate.Wait();
 
   ASSERT_TRUE(delegate.success());
 
   // Make sure we get back the bitmap we expect.
   const SkBitmap& found_image = delegate.bitmap();
   EXPECT_TRUE(gfx::BitmapsAreEqual(image, found_image));
 }
@@ skipping 27 matching lines @@
   // Set up a delegate to wait for the callback.
   BitmapFetcherTestDelegate delegate(kAsyncCall);
 
   BitmapFetcher fetcher(url, &delegate);
 
   url_fetcher_factory_->SetFakeResponse(url,
                                         std::string(),
                                         net::HTTP_INTERNAL_SERVER_ERROR,
                                         net::URLRequestStatus::FAILED);
 
-  fetcher.Start(
+  fetcher.Init(
       browser()->profile()->GetRequestContext(),
       std::string(),
       net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,
       net::LOAD_NORMAL);
+  fetcher.Start();
 
   // Blocks until test delegate is notified via a callback.
   delegate.Wait();
 
   EXPECT_FALSE(delegate.success());
 }
 
 IN_PROC_BROWSER_TEST_F(BitmapFetcherBrowserTest, HandleImageFailedTest) {
   GURL url("http://example.com/this-should-be-a-decode-failure");
   BitmapFetcherTestDelegate delegate(kAsyncCall);
   BitmapFetcher fetcher(url, &delegate);
   url_fetcher_factory_->SetFakeResponse(url,
                                         std::string("Not a real bitmap"),
                                         net::HTTP_OK,
                                         net::URLRequestStatus::SUCCESS);
 
-  fetcher.Start(
+  fetcher.Init(
       browser()->profile()->GetRequestContext(),
       std::string(),
       net::URLRequest::CLEAR_REFERRER_ON_TRANSITION_FROM_SECURE_TO_INSECURE,
       net::LOAD_NORMAL);
+  fetcher.Start();
 
   // Blocks until test delegate is notified via a callback.
   delegate.Wait();
 
   EXPECT_FALSE(delegate.success());
 }
 
 }  // namespace chrome