Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: sky/examples/stocks/lib/stock_list.dart

Issue 1097373002: [Effen] Prevent scrolling past the bottom of a scrollable list. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Move the creation of the OverscrollBehavior class to FixedHeightScrollable, since we already assumeā€¦ Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'package:sky/framework/animation/scroll_behavior.dart'; 5 import 'package:sky/framework/animation/scroll_behavior.dart';
6 import 'package:sky/framework/components/fixed_height_scrollable.dart'; 6 import 'package:sky/framework/components/fixed_height_scrollable.dart';
7 import 'package:sky/framework/fn.dart'; 7 import 'package:sky/framework/fn.dart';
8 import 'stock_data.dart'; 8 import 'stock_data.dart';
9 import 'stock_row.dart'; 9 import 'stock_row.dart';
10 10
11 class Stocklist extends FixedHeightScrollable { 11 class Stocklist extends FixedHeightScrollable {
12 String query; 12 String query;
13 List<Stock> stocks; 13 List<Stock> stocks;
14 14
15 Stocklist({ 15 Stocklist({
16 Object key, 16 Object key,
17 this.stocks, 17 this.stocks,
18 this.query 18 this.query
19 }) : super(key: key, scrollBehavior: new OverscrollBehavior()); 19 }) : super(key: key);
20 20
21 List<UINode> buildItems(int start, int count) { 21 List<UINode> buildItems(int start, int count) {
22 return stocks 22 var filteredStocks = stocks.where((stock) {
23 .where((stock) => query == null || stock.symbol.contains( 23 return query == null ||
24 new RegExp(query, caseSensitive: false))) 24 stock.symbol.contains(new RegExp(query, caseSensitive: false));
25 });
26 itemCount = filteredStocks.length;
abarth-chromium 2015/06/04 16:23:17 Won't this |length| query force the filter to be e
27 return filteredStocks
25 .skip(start) 28 .skip(start)
26 .take(count) 29 .take(count)
27 .map((stock) => new StockRow(stock: stock)) 30 .map((stock) => new StockRow(stock: stock))
28 .toList(growable: false); 31 .toList(growable: false);
29 } 32 }
30 } 33 }
OLDNEW
« no previous file with comments | « no previous file | sky/framework/animation/mechanics.dart » ('j') | sky/framework/animation/mechanics.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698