Chromium Code Reviews Chromium Code Reviews
Issue 1097353002:
typo in sherrifing docs (Closed)
Base URL: https://skia.googlesource.com/skia.git@master| OLD | NEW |
|---|---|
| 1 Tree Sheriffs Documentation | 1 Tree Sheriffs Documentation |
| 2 =========================== | 2 =========================== |
| 3 | 3 |
| 4 ### Contents ### | 4 ### Contents ### |
| 5 | 5 |
| 6 * [What does a sheriff do?](#what_is_a_sheriff) | 6 * [What does a sheriff do?](#what_is_a_sheriff) |
| 7 + [Skia tree](#skia_tree) | 7 + [Skia tree](#skia_tree) |
| 8 + [DEPS rolls](#deps_rolls) | 8 + [DEPS rolls](#deps_rolls) |
| 9 + [Gold and Perf](#gold_and_perf) | 9 + [Gold and Perf](#gold_and_perf) |
| 10 + [Documentation](#sheriff_doc) | 10 + [Documentation](#sheriff_doc) |
| (...skipping 15 matching lines...) Expand all Loading... | |
| 26 A sheriff keeps an eye on the tree, DEPS rolls, Gold tool and the Perf tool. | 26 A sheriff keeps an eye on the tree, DEPS rolls, Gold tool and the Perf tool. |
| 27 | 27 |
| 28 Below is a brief summary of what the sheriff does for each task: | 28 Below is a brief summary of what the sheriff does for each task: |
| 29 | 29 |
| 30 <a name="skia_tree"></a> | 30 <a name="skia_tree"></a> |
| 31 ### Skia tree | 31 ### Skia tree |
| 32 * Understand the [buildbots infrastructure](https://skia.org/dev/testing/buildbo t). | 32 * Understand the [buildbots infrastructure](https://skia.org/dev/testing/buildbo t). |
| 33 * Start watching the [status page](https://status.skia.org) for bot breakages. | 33 * Start watching the [status page](https://status.skia.org) for bot breakages. |
| 34 * Track down people responsible for breakages and revert broken changes if there is no easy fix. | 34 * Track down people responsible for breakages and revert broken changes if there is no easy fix. |
| 35 * Close and open the [tree](http://skia-tree-status.appspot.com). | 35 * Close and open the [tree](http://skia-tree-status.appspot.com). |
| 36 * Keep the builder comments on the [status page](https://status.skia.org) upto d ate. | 36 * Keep the builder comments on the [status page](https://status.skia.org) up to date. |
|
tfarina
2015/04/21 22:09:19
lgtm
| |
| 37 * File or follow up with [BreakingTheBuildbots bugs](https://code.google.com/p/s kia/issues/list?q=label:BreakingTheBuildbots). See the tip on [when to file bugs ](#when_to_file_bugs). | 37 * File or follow up with [BreakingTheBuildbots bugs](https://code.google.com/p/s kia/issues/list?q=label:BreakingTheBuildbots). See the tip on [when to file bugs ](#when_to_file_bugs). |
| 38 | 38 |
| 39 <a name="deps_rolls"></a> | 39 <a name="deps_rolls"></a> |
| 40 ### DEPS rolls | 40 ### DEPS rolls |
| 41 * Ensure that [AutoRoll Bot](https://skia-tree-status.appspot.com/set_arb_action )'s DEPS rolls land successfully. | 41 * Ensure that [AutoRoll Bot](https://skia-tree-status.appspot.com/set_arb_action )'s DEPS rolls land successfully. |
| 42 | 42 |
| 43 <a name="gold_and_perf"></a> | 43 <a name="gold_and_perf"></a> |
| 44 ### Gold and Perf | 44 ### Gold and Perf |
| 45 * Pay attention for new [Perf](https://perf.skia.org/) and [Gold](https://gold.s kia.org/) alerts (by clicking on the bell at the top right of the [status page]( https://status.skia.org)). | 45 * Pay attention for new [Perf](https://perf.skia.org/) and [Gold](https://gold.s kia.org/) alerts (by clicking on the bell at the top right of the [status page]( https://status.skia.org)). |
| 46 * The sheriff's duty here is to make sure that when developers introduce new ima ges or new perf regressions, that they are aware of what happened, and they use these tools to take appropriate action. | 46 * The sheriff's duty here is to make sure that when developers introduce new ima ges or new perf regressions, that they are aware of what happened, and they use these tools to take appropriate action. |
| (...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 152 * Add # comment about what has changed | 152 * Add # comment about what has changed |
| 153 * Add line(s) like the following after the comment: | 153 * Add line(s) like the following after the comment: |
| 154 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsRebaseline ] | 154 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsRebaseline ] |
| 155 * (if you took the second option above you can just edit the existing li ne(s)) | 155 * (if you took the second option above you can just edit the existing li ne(s)) |
| 156 | 156 |
| 157 * If you took the first/dispreferred option above: | 157 * If you took the first/dispreferred option above: |
| 158 * Wait for the Blink patch to roll into Chrome | 158 * Wait for the Blink patch to roll into Chrome |
| 159 * Create a Chrome patch that removes your suppressions from skia/skia_test_exp ectations.txt | 159 * Create a Chrome patch that removes your suppressions from skia/skia_test_exp ectations.txt |
| 160 | 160 |
| 161 | 161 |
| OLD | NEW |
