Plumb ConnectionAttempts from HttpNetworkTransaction to URLRequest.

net/url_request/url_request_job.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_
 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_
 
 #include <string>
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/power_monitor/power_observer.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/load_states.h"
 #include "net/base/net_export.h"
 #include "net/base/request_priority.h"
 #include "net/base/upload_progress.h"
 #include "net/cookies/canonical_cookie.h"
+#include "net/socket/connection_attempts.h"

[Randy Smith (Not in Mondays), 2015/05/01 17:03:44]

Replace with forward decl.

[Deprecated (see juliatuttle), 2015/05/04 19:53:37]

Can't, it's a typedef.

 #include "net/url_request/redirect_info.h"
 #include "net/url_request/url_request.h"
 #include "url/gurl.h"
 
 namespace net {
 
 class AuthChallengeInfo;
 class AuthCredentials;
 class CookieOptions;
 class Filter;
@@ skipping 187 matching lines @@
   // base::PowerObserver methods:
   // We invoke URLRequestJob::Kill on suspend (crbug.com/4606).
   void OnSuspend() override;
 
   // Called after a NetworkDelegate has been informed that the URLRequest
   // will be destroyed. This is used to track that no pending callbacks
   // exist at destruction time of the URLRequestJob, unless they have been
   // canceled by an explicit NetworkDelegate::NotifyURLRequestDestroyed() call.
   virtual void NotifyURLRequestDestroyed();
 
+  virtual void GetConnectionAttempts(ConnectionAttempts* out) const;

[Randy Smith (Not in Mondays), 2015/05/01 17:03:44]

I think commenting of method functionality is more important in base classes
than usual.  Maybe a note about what this is doing (though that's actually
pretty obvious from the signature) along with when during the job lifetime it's
appropriate to call it or something like that?  (I don't have strong feelings
about what should be in the comment, I just don't want people going "Yuck,
another random base class method I've got no clue about" when they see it.)

[Deprecated (see juliatuttle), 2015/05/04 19:53:37]

Done.

+
   // Given |policy|, |referrer|, and |redirect_destination|, returns the
   // referrer URL mandated by |request|'s referrer policy.
   static GURL ComputeReferrerForRedirect(URLRequest::ReferrerPolicy policy,
                                          const std::string& referrer,
                                          const GURL& redirect_destination);
 
  protected:
   friend class base::RefCounted<URLRequestJob>;
   ~URLRequestJob() override;
 
@@ skipping 190 matching lines @@
   NetworkDelegate* network_delegate_;
 
   base::WeakPtrFactory<URLRequestJob> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestJob);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_JOB_H_