Clean up fifo logcat watcher

Clean up fifo logcat watcher

- fix double newlines in test results
- reduce log spam (bug 151886)
- some pylint cleanup of the two affected files.

R=bulach@chromium.org,skyostil@chromium.org
BUG=151886
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158247

[bulach, 2012-09-24 09:47:17]

lgtm, thanks Isaac! I was about to do this, glad you got here first... just some
suggestions below:

https://codereview.chromium.org/10973004/diff/6001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/10973004/diff/6001/build/android/pylib/androi...
build/android/pylib/android_commands.py:1012: self.output = output
nit: self._output

https://codereview.chromium.org/10973004/diff/6001/build/android/pylib/test_p...
File build/android/pylib/test_package_apk.py (right):

https://codereview.chromium.org/10973004/diff/6001/build/android/pylib/test_p...
build/android/pylib/test_package_apk.py:62: def _WatchFifo(self, timeout):
nit: while at it, would you like to make logfile a param here?
then you can pass None in GetAllTests() below, and move 72 to 110 on
RUnTestsAndListResults..
this would fix 151886 :)

[Isaac (away), 2012-09-24 10:01:33]

http://goto.google.com/rkmnd

https://codereview.chromium.org/10973004/diff/6001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/10973004/diff/6001/build/android/pylib/androi...
build/android/pylib/android_commands.py:1012: self.output = output
On 2012/09/24 09:47:17, bulach wrote:
> nit: self._output

Done.

https://codereview.chromium.org/10973004/diff/6001/build/android/pylib/test_p...
File build/android/pylib/test_package_apk.py (right):

https://codereview.chromium.org/10973004/diff/6001/build/android/pylib/test_p...
build/android/pylib/test_package_apk.py:62: def _WatchFifo(self, timeout):
On 2012/09/24 09:47:17, bulach wrote:
> nit: while at it, would you like to make logfile a param here?
> then you can pass None in GetAllTests() below, and move 72 to 110 on
> RUnTestsAndListResults..
> this would fix 151886 :)

Done.

[commit-bot: I haz the power, 2012-09-24 10:05:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/10973004/3002

[Sami, 2012-09-24 10:38:06]

lgtm. Thanks Isaac, the logfiles keep getting prettier :)