Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1097283005: Always use a UI message loop in the GPU process on Windows. (Closed)

Created:
5 years, 8 months ago by Geoff Lang
Modified:
5 years, 8 months ago
Reviewers:
jbauman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always use a UI message loop in the GPU process on Windows. ANGLE can now create child windows and requires UI messages to be handled. Because it is not possible to determine if ANGLE will use a child window when creating surfaces, always use a UI message loop. BUG=angleproject:961 Committed: https://crrev.com/019d4f33ee70596e34bcf78706c3da4d2d70d4f1 Cr-Commit-Position: refs/heads/master@{#327140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M content/gpu/gpu_main.cc View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Geoff Lang
@jbauman: PTAL
5 years, 8 months ago (2015-04-22 14:34:28 UTC) #2
jbauman
lgtm
5 years, 8 months ago (2015-04-27 19:53:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097283005/1
5 years, 8 months ago (2015-04-27 19:54:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 21:39:48 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 21:40:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/019d4f33ee70596e34bcf78706c3da4d2d70d4f1
Cr-Commit-Position: refs/heads/master@{#327140}

Powered by Google App Engine
This is Rietveld 408576698