Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1097283004: Add toplevel trace event to MessagePumpLibevent::OnLibeventNotification (Closed)

Created:
5 years, 8 months ago by spang
Modified:
5 years, 8 months ago
Reviewers:
danakj, dsinclair
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add toplevel trace event to MessagePumpLibevent::OnLibeventNotification This adds a new top level trace span for work resulting from I/O notifications. Currently I/O triggered work may not show up at all in tracing (unlike work resulting from PostTask). BUG=none TEST=chrome://tracing on Chromebook Pixel. Input thread shows I/O spans rather than showing nothing. Committed: https://crrev.com/da537fb071ac3c6be575afa410895a2838af0f66 Cr-Commit-Position: refs/heads/master@{#326855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/message_loop/message_pump_libevent.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
5 years, 8 months ago (2015-04-21 17:11:59 UTC) #2
danakj
LGTM
5 years, 8 months ago (2015-04-24 18:09:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097283004/1
5 years, 8 months ago (2015-04-24 18:23:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 19:26:42 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 19:27:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da537fb071ac3c6be575afa410895a2838af0f66
Cr-Commit-Position: refs/heads/master@{#326855}

Powered by Google App Engine
This is Rietveld 408576698