src/scopeinfo.cc - Issue 1097283003: Resolve references to "this" the same way as normal variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scopeinfo.cc

Issue 1097283003: Resolve references to "this" the same way as normal variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master

Patch Set: Add TODO to fix fat-fingered "this" scoping in script context Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/scopeinfo.cc

diff --git a/src/scopeinfo.cc b/src/scopeinfo.cc

index 012744992fe783fa072249be7f7454de7699e7ca..4b079b990363fdf63eaccf755c45abf7fae33b5c 100644

--- a/src/scopeinfo.cc

+++ b/src/scopeinfo.cc

@@ -317,7 +317,8 @@ bool ScopeInfo::LocalIsSynthetic(int var) {

// with user declarations, the current temporaries like .generator_object and

// .result start with a dot, so we can use that as a flag. It's a hack!

Handle<String> name(LocalName(var));

- return name->length() > 0 && name->Get(0) == '.';

+ return (name->length() > 0 && name->Get(0) == '.') ||

+ name->Equals(*GetIsolate()->factory()->this_string());

}