src/heap/heap.h - Issue 1097283003: Resolve references to "this" the same way as normal variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.h

Issue 1097283003: Resolve references to "this" the same way as normal variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master

Patch Set: Add TODO to fix fat-fingered "this" scoping in script context Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/heap.h

diff --git a/src/heap/heap.h b/src/heap/heap.h

index dcf7bdea0ac812972304bd382d52b0a1f4c5eff2..638a9ce48d06d534b20f13aedd80970efbbc829e 100644

--- a/src/heap/heap.h

+++ b/src/heap/heap.h

@@ -227,6 +227,7 @@ namespace internal {

V(source_string, "source") \

V(source_url_string, "source_url") \

V(source_mapping_url_string, "source_mapping_url") \

+ V(this_string, "this") \

V(global_string, "global") \

V(ignore_case_string, "ignoreCase") \

V(multiline_string, "multiline") \