src/compiler/ast-graph-builder.h - Issue 1097283003: Resolve references to "this" the same way as normal variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.h

Issue 1097283003: Resolve references to "this" the same way as normal variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master

Patch Set: Add TODO to fix fat-fingered "this" scoping in script context Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-graph-builder.h

diff --git a/src/compiler/ast-graph-builder.h b/src/compiler/ast-graph-builder.h

index 74728ddf8516c1c55a9e86e0b5b4cf736bcfb79b..f9d447256f4eefb4d24b752f15196a30eb16abff 100644

--- a/src/compiler/ast-graph-builder.h

+++ b/src/compiler/ast-graph-builder.h

@@ -246,7 +246,7 @@ class AstGraphBuilder : public AstVisitor {

Node* BuildPatchReceiverToGlobalProxy(Node* receiver);

// Builders to create local function, script and block contexts.

- Node* BuildLocalFunctionContext(Node* context);

+ Node* BuildLocalFunctionContext(Node* context, Node* patched_receiver);

Node* BuildLocalScriptContext(Scope* scope);

Node* BuildLocalBlockContext(Scope* scope);