src/variables.cc - Issue 1097283003: Resolve references to "this" the same way as normal variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/variables.cc

Issue 1097283003: Resolve references to "this" the same way as normal variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master

Patch Set: Add tests for "this" scoping in arrow functions Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/variables.cc

diff --git a/src/variables.cc b/src/variables.cc

index c0b8bd784353aa0ad349689b30ce7578de80e116..0c94d75439d731ffa6b29cf602b8c11520343073 100644

--- a/src/variables.cc

+++ b/src/variables.cc

@@ -59,8 +59,8 @@ bool Variable::IsGlobalObjectProperty() const {

// Temporaries are never global, they must always be allocated in the

// activation frame.

return (IsDynamicVariableMode(mode_) ||

- (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_)))

- && scope_ != NULL && scope_->is_script_scope();

+ (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_))) &&

+ scope_ != NULL && scope_->is_script_scope() && !is_this();

}