Resolve references to "this" the same way as normal variables

src/compiler/ast-graph-builder.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/ast-graph-builder.h"
 
 #include "src/compiler.h"
 #include "src/compiler/ast-loop-assignment-analyzer.h"
 #include "src/compiler/control-builders.h"
 #include "src/compiler/js-type-feedback.h"
@@ skipping 450 matching lines @@
 
   // Initialize the incoming context.
   CreateFunctionContext(constant_context);
   ContextScope incoming(this, scope, function_context_.get());
 
   // Initialize control scope.
   ControlScope control(this);
 
   // Build receiver check for sloppy mode if necessary.
   // TODO(mstarzinger/verwaest): Should this be moved back into the CallIC?
-  Node* original_receiver = env.Lookup(scope->receiver());
-  Node* patched_receiver = BuildPatchReceiverToGlobalProxy(original_receiver);
-  env.Bind(scope->receiver(), patched_receiver);
+  if (scope->has_this_declaration() && scope->receiver()->IsStackAllocated()) {
+    // If the receiver is context-allocated, we patch it in
+    // BuildLocalFunctionContext.
+    Node* original_receiver = env.Lookup(scope->receiver());
+    Node* patched_receiver = BuildPatchReceiverToGlobalProxy(original_receiver);

[Michael Starzinger, 2015/04/22 10:59:21]

Instead of having two call-sites of BuildPatchReceiverToGlobalProxy, could we
instead add a "Node* function_receiver_" field to the AstGraphBuilder? That
would allow us to ...

- initially set that field to Parameter(0) unconditionally
- conditionally patch it if scope->has_this_declaration()
- use that field in AstGraphBuilder::BuildLocalFunctionContext

[Michael Starzinger, 2015/04/22 11:17:53]

Or alternatively pass the patched_receiver as an argument to
AstGraphBuilder::BuildLocalFunctionContext, that might be even cleaner.

[wingo, 2015/04/22 13:05:23]

A bit squirrely, but done.

+    env.Bind(scope->receiver(), patched_receiver);
+  }
 
   // Build function context only if there are context allocated variables.
   int heap_slots = info()->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
   if (heap_slots > 0) {
     // Push a new inner context scope for the function.
     Node* inner_context = BuildLocalFunctionContext(function_context_.get());
     ContextScope top_context(this, scope, inner_context);
     CreateGraphBody(stack_check);
   } else {
     // Simply use the outer function context in building the graph.
@@ skipping 1657 matching lines @@
   if (possibly_eval && args->length() > 0) {
     int arg_count = args->length();
 
     // Extract callee and source string from the environment.
     Node* callee = environment()->Peek(arg_count + 1);
     Node* source = environment()->Peek(arg_count - 1);
 
     // Create node to ask for help resolving potential eval call. This will
     // provide a fully resolved callee and the corresponding receiver.
     Node* function = GetFunctionClosure();
-    Node* receiver = environment()->Lookup(info()->scope()->receiver());
+    // TODO(wingo): ResolvePossibleDirectEval doesn't really need a receiver,
+    // now that eval scopes don't have "this" declarations.  Remove this hack
+    // once ResolvePossibleDirectEval changes.

[Michael Starzinger, 2015/04/22 10:59:21]

Does this mean that the "receiver" input to ResolvePossibleDirectEval will
disappear completely? That would be awesome then, and I can totally live with
this TODO then. :)

[wingo, 2015/04/22 13:05:23]

Yes I think so, and the second return value from ResolvePossibleDirectEval would
also go away, methinks :)

[Michael Starzinger, 2015/04/22 13:26:19]

Woot! That would be the awesomez! :)

+    Node* receiver;
+    {
+      Variable* variable = info()->scope()->LookupThis();
+      if (variable->IsStackAllocated()) {
+        receiver = environment()->Lookup(variable);
+      } else {
+        DCHECK(variable->IsContextSlot());
+        int depth = current_scope()->ContextChainLength(variable->scope());
+        bool immutable = variable->maybe_assigned() == kNotAssigned;
+        const Operator* op =
+            javascript()->LoadContext(depth, variable->index(), immutable);
+        receiver = NewNode(op, current_context());
+      }
+    }
     Node* language = jsgraph()->Constant(language_mode());
     Node* position = jsgraph()->Constant(info()->scope()->start_position());
     const Operator* op =
         javascript()->CallRuntime(Runtime::kResolvePossiblyDirectEval, 6);
     Node* pair =
         NewNode(op, callee, source, function, receiver, language, position);
     PrepareFrameState(pair, expr->EvalOrLookupId(),
                       OutputFrameStateCombine::PokeAt(arg_count + 1));
     Node* new_callee = NewNode(common()->Projection(0), pair);
     Node* new_receiver = NewNode(common()->Projection(1), pair);
@@ skipping 480 matching lines @@
 
 Node* AstGraphBuilder::BuildLocalFunctionContext(Node* context) {
   Node* closure = GetFunctionClosure();
 
   // Allocate a new local context.
   Node* local_context =
       info()->scope()->is_script_scope()
           ? BuildLocalScriptContext(info()->scope())
           : NewNode(javascript()->CreateFunctionContext(), closure);
 
+  if (info()->scope()->has_this_declaration() &&
+      info()->scope()->receiver()->IsContextSlot()) {
+    Node* original_receiver = NewNode(common()->Parameter(0), graph()->start());
+    Node* patched_receiver = BuildPatchReceiverToGlobalProxy(original_receiver);
+    // Context variable (at bottom of the context chain).
+    Variable* variable = info()->scope()->receiver();
+    DCHECK_EQ(0, info()->scope()->ContextChainLength(variable->scope()));
+    const Operator* op = javascript()->StoreContext(0, variable->index());
+    NewNode(op, local_context, patched_receiver);
+  }
+
   // Copy parameters into context if necessary.
   int num_parameters = info()->scope()->num_parameters();
   for (int i = 0; i < num_parameters; i++) {
     Variable* variable = info()->scope()->parameter(i);
     if (!variable->IsContextSlot()) continue;
     // Temporary parameter node. The parameter indices are shifted by 1
     // (receiver is parameter index -1 but environment index 0).
     Node* parameter = NewNode(common()->Parameter(i + 1), graph()->start());
     // Context variable (at bottom of the context chain).
     DCHECK_EQ(0, info()->scope()->ContextChainLength(variable->scope()));
@@ skipping 888 matching lines @@
     // Phi does not exist yet, introduce one.
     value = NewPhi(inputs, value, control);
     value->ReplaceInput(inputs - 1, other);
   }
   return value;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8