Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: src/compiler/ast-graph-builder.h

Issue 1097283003: Resolve references to "this" the same way as normal variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Add tests for "this" scoping in arrow functions Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/ast-graph-builder.cc » ('j') | src/scopes.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_AST_GRAPH_BUILDER_H_ 5 #ifndef V8_COMPILER_AST_GRAPH_BUILDER_H_
6 #define V8_COMPILER_AST_GRAPH_BUILDER_H_ 6 #define V8_COMPILER_AST_GRAPH_BUILDER_H_
7 7
8 #include "src/ast.h" 8 #include "src/ast.h"
9 #include "src/compiler/js-graph.h" 9 #include "src/compiler/js-graph.h"
10 #include "src/compiler/liveness-analyzer.h" 10 #include "src/compiler/liveness-analyzer.h"
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 239
240 // =========================================================================== 240 // ===========================================================================
241 // The following build methods all generate graph fragments and return one 241 // The following build methods all generate graph fragments and return one
242 // resulting node. The operand stack height remains the same, variables and 242 // resulting node. The operand stack height remains the same, variables and
243 // other dependencies tracked by the environment might be mutated though. 243 // other dependencies tracked by the environment might be mutated though.
244 244
245 // Builder to create a receiver check for sloppy mode. 245 // Builder to create a receiver check for sloppy mode.
246 Node* BuildPatchReceiverToGlobalProxy(Node* receiver); 246 Node* BuildPatchReceiverToGlobalProxy(Node* receiver);
247 247
248 // Builders to create local function, script and block contexts. 248 // Builders to create local function, script and block contexts.
249 Node* BuildLocalFunctionContext(Node* context); 249 Node* BuildLocalFunctionContext(Node* context, Node* patched_receiver);
250 Node* BuildLocalScriptContext(Scope* scope); 250 Node* BuildLocalScriptContext(Scope* scope);
251 Node* BuildLocalBlockContext(Scope* scope); 251 Node* BuildLocalBlockContext(Scope* scope);
252 252
253 // Builder to create an arguments object if it is used. 253 // Builder to create an arguments object if it is used.
254 Node* BuildArgumentsObject(Variable* arguments); 254 Node* BuildArgumentsObject(Variable* arguments);
255 255
256 // Builder to create an array of rest parameters if used 256 // Builder to create an array of rest parameters if used
257 Node* BuildRestArgumentsArray(Variable* rest, int index); 257 Node* BuildRestArgumentsArray(Variable* rest, int index);
258 258
259 // Builders for variable load and assignment. 259 // Builders for variable load and assignment.
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 512
513 // Prepare environment to be used as loop header. 513 // Prepare environment to be used as loop header.
514 void PrepareForLoop(BitVector* assigned, bool is_osr = false); 514 void PrepareForLoop(BitVector* assigned, bool is_osr = false);
515 }; 515 };
516 516
517 } // namespace compiler 517 } // namespace compiler
518 } // namespace internal 518 } // namespace internal
519 } // namespace v8 519 } // namespace v8
520 520
521 #endif // V8_COMPILER_AST_GRAPH_BUILDER_H_ 521 #endif // V8_COMPILER_AST_GRAPH_BUILDER_H_
OLDNEW
« no previous file with comments | « no previous file | src/compiler/ast-graph-builder.cc » ('j') | src/scopes.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698