Issue 1097263003: Revert of Remove special theming for CardUnmaskPrompt since it's now automatic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1097263003: Revert of Remove special theming for CardUnmaskPrompt since it's now automatic (Closed)

Created:
5 years, 8 months ago by Evan Stade

Modified:
5 years, 8 months ago

Reviewers:
aurimas (slooooooooow), newt (away)

CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Remove special theming for CardUnmaskPrompt since it's now automatic (patchset #2 id:20001 of https://codereview.chromium.org/1096263005/) Reason for revert: automatic alert dialog styling was reverted, so revert this as well for now. Original issue's description: > Remove special theming for CardUnmaskPrompt since it's now automatic > for all alert dialogs. > > BUG=463576 > > Committed: https://crrev.com/d9456757bec482f2b27cf75ef7fa2109af0500a6 > Cr-Commit-Position: refs/heads/master@{#326869} TBR=newt@chromium.org,aurimas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463576 Committed: https://crrev.com/a8c58ed5902ed6cecdd7a86ae9d2aca00ad9e30c Cr-Commit-Position: refs/heads/master@{#326899}

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -1 line)			Patch
M	chrome/android/java/res/values-v17/styles.xml	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	chrome/android/java/res/values/colors.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Evan Stade

Created Revert of Remove special theming for CardUnmaskPrompt since it's now automatic

5 years, 8 months ago (2015-04-24 22:11:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097263003/1

5 years, 8 months ago (2015-04-24 22:11:56 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 22:15:35 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a8c58ed5902ed6cecdd7a86ae9d2aca00ad9e30c
Cr-Commit-Position: refs/heads/master@{#326899}