Add libs to get information about or manipulate a buildbot master.

Add libs to get information about or manipulate a buildbot master.

This CL depends on https://chromiumcodereview.appspot.com/1094253002/.

BUG=479059
Committed: https://chromium.googlesource.com/infra/infra/+/8205c51503f7efa5024d05a98a39069c98fc259f

[ghost stip (do not use), 2015-04-23 21:58:34]

stip@chromium.org changed reviewers:
+ agable@chromium.org, iannucci@chromium.org

[ghost stip (do not use), 2015-04-23 21:59:05]

ptal.

I'm getting a coverage error in master_test.py, somehow I'm missing two
branches. Other than that this CL is ready for review.

[agable, 2015-04-27 20:01:46]

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
File infra/libs/buildbot/master.py (right):

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:4: 
Since the only file in this directory is called master.py, not buildbot.py, it
suggests that this library will end up containing other pieces. As such, I'd
suggest populating __init__.py with the pieces of the library that you'd like to
expose publicly as the API.

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:11: from dateutil.parser import parse
nit: "from" import statements come in a separate block after all the regular
imports

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:23: # Derived from
http://stackoverflow.com/a/6940314.
Include in the comment here or in the docstring that sending signal 0 is
equivalent to an "are you alive" ping so that people don't have to follow the
link just for that.

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:60: for line in f:
Read the file backwards and search for the first line that looks like an action.
Less state, and results in processing fewer lines (though they'll still all get
read into memory).

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:100: if os.path.exists(build_internal_dir):
I'm a little leery about infra.git knowing about build_internal, since it isn't
in the deps file. But if we do actually roll out the Infra Repo Deployment Plan,
then this will be kosher. And it's better than build knowing about
build_internal anyway.

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:109: assert len(matches) < 2
Add an error message, plain asserts in libraries make me sad.

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:124: """Determine whether the master is accepting
new builds or not."""
Note in big huge words that this only works for masters running locally. Someone
might expect to be able to call this on their local machine and find out in
master.chromium.mac is up.

[ghost stip (do not use), 2015-04-27 23:42:18]

addressed comments, ptal!

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
File infra/libs/buildbot/master.py (right):

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:4: 
On 2015/04/27 20:01:45, agable wrote:
> Since the only file in this directory is called master.py, not buildbot.py, it
> suggests that this library will end up containing other pieces. As such, I'd
> suggest populating __init__.py with the pieces of the library that you'd like
to
> expose publicly as the API.

Done.

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:11: from dateutil.parser import parse
On 2015/04/27 20:01:45, agable wrote:
> nit: "from" import statements come in a separate block after all the regular
> imports

Done.

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:23: # Derived from
http://stackoverflow.com/a/6940314.
On 2015/04/27 20:01:45, agable wrote:
> Include in the comment here or in the docstring that sending signal 0 is
> equivalent to an "are you alive" ping so that people don't have to follow the
> link just for that.

Done.

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:60: for line in f:
On 2015/04/27 20:01:45, agable wrote:
> Read the file backwards and search for the first line that looks like an
action.
> Less state, and results in processing fewer lines (though they'll still all
get
> read into memory).

it's way cleaner now. nice

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:100: if os.path.exists(build_internal_dir):
On 2015/04/27 20:01:45, agable wrote:
> I'm a little leery about infra.git knowing about build_internal, since it
isn't
> in the deps file. But if we do actually roll out the Infra Repo Deployment
Plan,
> then this will be kosher. And it's better than build knowing about
> build_internal anyway.

yeah. I actually with mastermap.py would just automagically use internal data if
it saw it, but this was the best I could come up with

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:109: assert len(matches) < 2
On 2015/04/27 20:01:45, agable wrote:
> Add an error message, plain asserts in libraries make me sad.

Done.

https://codereview.chromium.org/1097233002/diff/20001/infra/libs/buildbot/mas...
infra/libs/buildbot/master.py:124: """Determine whether the master is accepting
new builds or not."""
On 2015/04/27 20:01:45, agable wrote:
> Note in big huge words that this only works for masters running locally.
Someone
> might expect to be able to call this on their local machine and find out in
> master.chromium.mac is up.

Done.

https://codereview.chromium.org/1097233002/diff/40001/bootstrap/deps.pyl
File bootstrap/deps.pyl (right):

https://codereview.chromium.org/1097233002/diff/40001/bootstrap/deps.pyl#newc...
bootstrap/deps.pyl:25: 'build': '1',
these were from a rebase

[agable, 2015-04-28 00:44:15]

lgtm

[ghost stip (do not use), 2015-04-28 00:51:13]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2015-04-28 00:51:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1097233002/60001

[commit-bot: I haz the power, 2015-04-28 00:55:38]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/8205c51503f7efa5024d05a98a390...