Source/devtools/front_end/ui/Dialog.js - Issue 1097163004: DevTools: zoom frames upon double click, iterate over frames using arrows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ui/Dialog.js

Issue 1097163004: DevTools: zoom frames upon double click, iterate over frames using arrows. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/network/NetworkFilmStripView.js ('K') | « Source/devtools/front_end/sources/FilteredItemSelectionDialog.js ('k') | Source/devtools/front_end/ui_lazy/OverviewGrid.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/ui/Dialog.js

diff --git a/Source/devtools/front_end/ui/Dialog.js b/Source/devtools/front_end/ui/Dialog.js

index c53f0fd9d2cfdea759d3b745d836419dadee8fcf..d885dfcf43ea50a208367a41951e4cdc41e7c138 100644

--- a/Source/devtools/front_end/ui/Dialog.js

+++ b/Source/devtools/front_end/ui/Dialog.js

@@ -140,11 +140,11 @@ WebInspector.Dialog.prototype = {

/**

* @constructor

* @extends {WebInspector.Object}

+ * @param {!Element} element

-WebInspector.DialogDelegate = function()

+WebInspector.DialogDelegate = function(element)

dgozman 2015/04/22 10:16:54 Make it className instead of element, since they a

pfeldman 2015/04/22 12:13:12 I'll just create this div here and let clients add

{

- /** @type {!Element} */

- this.element;

+ this.element = element;

}

WebInspector.DialogDelegate.prototype = {