Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1097163004: DevTools: zoom frames upon double click, iterate over frames using arrows. (Closed)

Created:
5 years, 8 months ago by pfeldman
Modified:
5 years, 8 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: zoom frames upon double click, iterate over frames using arrows. BUG=427418 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194235

Patch Set 1 #

Total comments: 6

Patch Set 2 : review comments addressed #

Patch Set 3 : rolled back a tiny bit to make bots happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -20 lines) Patch
M Source/devtools/front_end/dialog.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/network/NetworkFilmStripView.js View 1 6 chunks +130 lines, -6 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/network/networkPanel.css View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/devtools/front_end/settings/EditFileSystemDialog.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/settings/FrameworkBlackboxDialog.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/source_frame/GoToLineDialog.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/sources/AddSourceMapURLDialog.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/sources/FilteredItemSelectionDialog.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/Dialog.js View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pfeldman
5 years, 8 months ago (2015-04-21 18:11:09 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1097163004/diff/1/Source/devtools/front_end/network/NetworkFilmStripView.js File Source/devtools/front_end/network/NetworkFilmStripView.js (right): https://codereview.chromium.org/1097163004/diff/1/Source/devtools/front_end/network/NetworkFilmStripView.js#newcode233 Source/devtools/front_end/network/NetworkFilmStripView.js:233: WebInspector.Dialog.show(WebInspector.Dialog.modalHostView().element, new WebInspector.NetworkFilmStripFrame.DialogDelegate(this)); First parameter should be NetworkPanel.element. ...
5 years, 8 months ago (2015-04-22 10:16:54 UTC) #3
pfeldman
https://codereview.chromium.org/1097163004/diff/1/Source/devtools/front_end/network/NetworkFilmStripView.js File Source/devtools/front_end/network/NetworkFilmStripView.js (right): https://codereview.chromium.org/1097163004/diff/1/Source/devtools/front_end/network/NetworkFilmStripView.js#newcode233 Source/devtools/front_end/network/NetworkFilmStripView.js:233: WebInspector.Dialog.show(WebInspector.Dialog.modalHostView().element, new WebInspector.NetworkFilmStripFrame.DialogDelegate(this)); On 2015/04/22 10:16:54, dgozman wrote: > ...
5 years, 8 months ago (2015-04-22 12:13:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097163004/20001
5 years, 8 months ago (2015-04-22 12:13:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/53005)
5 years, 8 months ago (2015-04-22 16:27:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097163004/40001
5 years, 8 months ago (2015-04-22 16:56:07 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 22:53:30 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194235

Powered by Google App Engine
This is Rietveld 408576698