Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1097153002: NaCl/GYP: remove references to prep_toolchain. (Closed)

Created:
5 years, 8 months ago by Nick Bray (chromium)
Modified:
5 years, 8 months ago
Reviewers:
Mark Seaborn, jam
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, plundblad+watch_chromium.org, chromoting-reviews_chromium.org, binji+watch_chromium.org, nektar+watch_chromium.org, tdresser+watch_chromium.org, jam, rickyz+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, je_julie(Not used), darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, erikwright+watch_chromium.org, jdduke+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl/GYP: remove references to prep_toolchain. prep_toolchain is now a no-op. BUG=456902 Committed: https://crrev.com/e9705fd6b87e9487773f58430aecc542e300911d Cr-Commit-Position: refs/heads/master@{#326044}

Patch Set 1 #

Patch Set 2 : Edit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -119 lines) Patch
M base/base_nacl.gyp View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/test/data/nacl/nacl_test_data.gyp View 26 chunks +0 lines, -38 lines 0 comments Download
M components/nacl_nonsfi.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/tracing_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_nacl_nonsfi.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M crypto/crypto_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/command_buffer_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gpu_nacl.gyp View 5 chunks +0 lines, -5 lines 0 comments Download
M ipc/ipc_nacl.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M jingle/jingle_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M media/media_nacl.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M mojo/mojo_nacl_untrusted.gyp View 1 3 chunks +0 lines, -3 lines 0 comments Download
M native_client_sdk/native_client_sdk_untrusted.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M net/net_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/untrusted/irt_stub/irt_stub.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp View 3 chunks +0 lines, -9 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_ipc_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_nacl.gyp View 2 chunks +0 lines, -7 lines 0 comments Download
M ppapi/ppapi_proxy_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_shared_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_key_tester.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/remoting_nacl.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
M sandbox/sandbox_nacl_nonsfi.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/boringssl/boringssl_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/jsoncpp/jsoncpp_nacl.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/libevent/libevent_nacl_nonsfi.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/libjingle/libjingle_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/liblouis/liblouis_nacl.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/modp_b64/modp_b64_nacl.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/opus/opus_nacl.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/protobuf/protobuf_nacl.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/usrsctp/usrsctp_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/latency_info_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Nick Bray (chromium)
Note: I will NOT be seeking OWNERS reviews for this CL. prep_toolchain ultimately infected too ...
5 years, 8 months ago (2015-04-20 21:07:41 UTC) #1
Nick Bray (chromium)
Whoops, forgot reviewers. mseaborn@ for domain knowledge. jam@ for top level owner, close enough minus ...
5 years, 8 months ago (2015-04-20 21:10:54 UTC) #3
Mark Seaborn
Please state in the commit message that prep_toolchain is now a no-op, in order to ...
5 years, 8 months ago (2015-04-20 22:21:29 UTC) #4
jam
rubberstamp lgtm
5 years, 8 months ago (2015-04-21 00:18:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097153002/20001
5 years, 8 months ago (2015-04-21 16:03:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 16:07:03 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 16:07:56 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9705fd6b87e9487773f58430aecc542e300911d
Cr-Commit-Position: refs/heads/master@{#326044}

Powered by Google App Engine
This is Rietveld 408576698