Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1097053008: Hand cursor on hover close & back buttons (Closed)

Created:
5 years, 8 months ago by Greg Levin
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hand cursor on hover close & back buttons BUG=478428 TEST=Hover mouse over Back and Close buttons in new GAIA login (for Add person, Create new account, etc). Cursor should change to pointer hand. Committed: https://crrev.com/30b23f7d633f7065b9b237f3aab3f04a067d21f2 Cr-Commit-Position: refs/heads/master@{#326857}

Patch Set 1 #

Patch Set 2 : Also for oauth webview buttons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.css View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Greg Levin
Please have a look!
5 years, 8 months ago (2015-04-23 15:54:29 UTC) #2
Nikita (slow)
Please also apply similar changes for enrollment UI buttons. It is implemented separately: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.css&q=oauth-enroll-cancel-button&sq=package:chromium&type=cs&l=95
5 years, 8 months ago (2015-04-23 16:23:22 UTC) #4
Greg Levin
Done. Please have another look!
5 years, 8 months ago (2015-04-23 23:45:32 UTC) #6
Dmitry Polukhin
lgtm
5 years, 8 months ago (2015-04-24 07:14:05 UTC) #7
Nikita (slow)
lgtm
5 years, 8 months ago (2015-04-24 18:56:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097053008/40001
5 years, 8 months ago (2015-04-24 18:57:54 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-24 19:31:49 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 19:32:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30b23f7d633f7065b9b237f3aab3f04a067d21f2
Cr-Commit-Position: refs/heads/master@{#326857}

Powered by Google App Engine
This is Rietveld 408576698