Drop some dead code from FilterEffect

Drop some dead code from FilterEffect

Remove the following and associated getters/setters:

 FilterEffect::m_alphaImage
 FilterEffect::m_resultColorSpace
 FilterEffect::clearResultsRecursive()
 FilterEffect::getSourceRect()

Also remove declarations that lack definitions and a few unused
includes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194041

[fs, 2015-04-20 15:18:22]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, senorblanco@chromium.org

[Stephen White, 2015-04-20 15:35:43]

LGTM

https://codereview.chromium.org/1097053004/diff/1/Source/platform/graphics/fi...
File Source/platform/graphics/filters/FEDisplacementMap.cpp (left):

https://codereview.chromium.org/1097053004/diff/1/Source/platform/graphics/fi...
Source/platform/graphics/filters/FEDisplacementMap.cpp:99: // and does not apply
to the 'in' source image. The 'in' source image must remain in its
This points out that there may be a bug in
FEDisplacementMap::createImageFilter(). Likely it should be passing
inputEffect(0)->operatingColorspace() to the first call to builder->builder(),
not operatingColorSpace().

If so, we're probably missing test coverage here.

[fs, 2015-04-20 15:59:29]

https://codereview.chromium.org/1097053004/diff/1/Source/platform/graphics/fi...
File Source/platform/graphics/filters/FEDisplacementMap.cpp (left):

https://codereview.chromium.org/1097053004/diff/1/Source/platform/graphics/fi...
Source/platform/graphics/filters/FEDisplacementMap.cpp:99: // and does not apply
to the 'in' source image. The 'in' source image must remain in its
On 2015/04/20 15:35:43, Stephen White wrote:
> This points out that there may be a bug in
> FEDisplacementMap::createImageFilter(). Likely it should be passing
> inputEffect(0)->operatingColorspace() to the first call to builder->builder(),
> not operatingColorSpace().
> 
> If so, we're probably missing test coverage here.

Yes, I noticed this discrepancy too... The commit that added this code [1], did
add tests too though, so I guess we need to check why that didn't notice it...

[1]
https://chromium.googlesource.com/chromium/blink/+/7d24fcc63dadc6a9e16159615e...

[fs, 2015-04-20 16:23:31]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-04-20 16:24:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1097053004/1

[commit-bot: I haz the power, 2015-04-20 18:09:34]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194041