Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1097043002: Request char* return type explicitly from rtc::Buffer::data() (Closed)

Created:
5 years, 8 months ago by kwiberg-chromium
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Request char* return type explicitly from rtc::Buffer::data() rtc::Buffer::data() will soon start defaulting to uint8_t* for its return type, so we have to start requesting char* explicitly. Committed: https://crrev.com/356fb21277972ae096eaefacb1e06da106b48bb1 Cr-Commit-Position: refs/heads/master@{#327468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/media/rtc_data_channel_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097043002/1
5 years, 8 months ago (2015-04-20 12:33:53 UTC) #2
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 8 months ago (2015-04-20 12:33:55 UTC) #4
tommi (sloooow) - chröme
lgtm
5 years, 8 months ago (2015-04-24 13:24:55 UTC) #7
tommi (sloooow) - chröme
lgtm
5 years, 8 months ago (2015-04-24 13:25:19 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097043002/1
5 years, 7 months ago (2015-04-29 09:18:29 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-29 10:25:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097043002/1
5 years, 7 months ago (2015-04-29 11:04:38 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 11:05:18 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 11:06:14 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/356fb21277972ae096eaefacb1e06da106b48bb1
Cr-Commit-Position: refs/heads/master@{#327468}

Powered by Google App Engine
This is Rietveld 408576698