Log ChromeToMobile search and auth errors to UMA and INFO.

chrome/browser/chrome_to_mobile_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_to_mobile_service.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/guid.h"
@@ skipping 376 matching lines @@
     if (!content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
                                           task_queue_.front())) {
       NOTREACHED();
     }
     task_queue_.pop();
   }
 }
 
 void ChromeToMobileService::OnGetTokenFailure(
     const GoogleServiceAuthError& error) {
+  // Log a general auth error metric for the "ChromeToMobile.Service" histogram.
   LogMetric(BAD_TOKEN);
+  // Log a more detailed metric for the "ChromeToMobile.AuthError" histogram.
+  UMA_HISTOGRAM_ENUMERATION("ChromeToMobile.AuthError", error.state(),
+                            GoogleServiceAuthError::NUM_STATES);
+  LOG(INFO) << "ChromeToMobile auth failed: " << error.ToString();

[sky, 2012/09/24 14:00:25]

Use VLOG

[msw, 2012/09/24 17:23:20]

Done.

+
   access_token_.clear();
   access_token_fetcher_.reset();
   auth_retry_timer_.Stop();
 
   base::TimeDelta delay = std::max(base::TimeDelta::FromHours(kDelayHours),
                                    auth_retry_timer_.GetCurrentDelay() * 2);
   auth_retry_timer_.Start(FROM_HERE, delay, this,
                           &ChromeToMobileService::RequestAccessToken);
 
   // Clear the mobile list, which may be (or become) out of date.
@@ skipping 179 matching lines @@
   search_request->Start();
 }
 
 void ChromeToMobileService::HandleSearchResponse(
     const net::URLFetcher* source) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   DCHECK_EQ(source->GetURL(), GetSearchURL(cloud_print_url_));
 
   ListValue mobiles;
   std::string data;
+  bool success = false;
   ListValue* list = NULL;
   DictionaryValue* dictionary = NULL;
   source->GetResponseAsString(&data);
   scoped_ptr<Value> json(base::JSONReader::Read(data));
-  if (json.get() && json->GetAsDictionary(&dictionary) && dictionary &&
-      dictionary->GetList(cloud_print::kPrinterListValue, &list)) {
-    std::string type, name, id;
-    DictionaryValue* printer = NULL;
-    DictionaryValue* mobile = NULL;
-    for (size_t index = 0; index < list->GetSize(); ++index) {
-      if (list->GetDictionary(index, &printer) &&
-          printer->GetString("type", &type) &&
-          (type.compare(kTypeAndroid) == 0 || type.compare(kTypeIOS) == 0)) {
-        // Copy just the requisite values from the full |printer| definition.
-        if (printer->GetString("displayName", &name) &&
-            printer->GetString("id", &id)) {
-          mobile = new DictionaryValue();
-          mobile->SetString("type", type);
-          mobile->SetString("name", name);
-          mobile->SetString("id", id);
-          mobiles.Append(mobile);
-        } else {
-          NOTREACHED();
+  if (json.get() && json->GetAsDictionary(&dictionary) && dictionary) {
+    dictionary->GetBoolean("success", &success);
+    if (dictionary->GetList(cloud_print::kPrinterListValue, &list)) {
+      std::string type, name, id;
+      DictionaryValue* printer = NULL;
+      DictionaryValue* mobile = NULL;
+      for (size_t index = 0; index < list->GetSize(); ++index) {
+        if (list->GetDictionary(index, &printer) &&
+            printer->GetString("type", &type) &&
+            (type.compare(kTypeAndroid) == 0 || type.compare(kTypeIOS) == 0)) {
+          // Copy just the requisite values from the full |printer| definition.
+          if (printer->GetString("displayName", &name) &&
+              printer->GetString("id", &id)) {
+            mobile = new DictionaryValue();
+            mobile->SetString("type", type);
+            mobile->SetString("name", name);
+            mobile->SetString("id", id);
+            mobiles.Append(mobile);
+          } else {
+            NOTREACHED();
+          }
         }
       }
     }
   } else if (source->GetResponseCode() == net::HTTP_FORBIDDEN) {
     LogMetric(BAD_SEARCH_AUTH);
     // Invalidate the access token and retry a delayed search on access errors.
     access_token_.clear();
     search_retry_timer_.Stop();
     base::TimeDelta delay = std::max(base::TimeDelta::FromHours(kDelayHours),
                                      search_retry_timer_.GetCurrentDelay() * 2);
     search_retry_timer_.Start(FROM_HERE, delay, this,
                               &ChromeToMobileService::RequestDeviceSearch);
   } else {
     LogMetric(BAD_SEARCH_OTHER);
   }
 
   // Update the cached mobile device list in profile prefs.
   profile_->GetPrefs()->Set(prefs::kChromeToMobileDeviceList, mobiles);
+
   if (HasMobiles())
     LogMetric(DEVICES_AVAILABLE);
+  LogMetric(success ? SEARCH_SUCCESS : SEARCH_ERROR);
+  LOG_IF(INFO, !success) << "ChromeToMobile search failed (" <<

[sky, 2012/09/24 14:00:25]

VLOG

[msw, 2012/09/24 17:23:20]

Done.

+                            source->GetResponseCode() << "): " << data;
+
   UpdateCommandState();
 }
 
 void ChromeToMobileService::HandleSubmitResponse(
     const net::URLFetcher* source) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   // Get the success value from the cloud print server response data.
   std::string data;
   bool success = false;
   source->GetResponseAsString(&data);
   DictionaryValue* dictionary = NULL;
   scoped_ptr<Value> json(base::JSONReader::Read(data));
   if (json.get() && json->GetAsDictionary(&dictionary) && dictionary) {
     dictionary->GetBoolean("success", &success);
     int error_code = -1;
     if (dictionary->GetInteger("errorCode", &error_code))
       LogMetric(error_code == 407 ? BAD_SEND_407 : BAD_SEND_ERROR);
   } else if (source->GetResponseCode() == net::HTTP_FORBIDDEN) {
     LogMetric(BAD_SEND_AUTH);
   } else {
     LogMetric(BAD_SEND_OTHER);
   }
 
   // Log each URL and [DELAYED_]SNAPSHOT job submission response.
   LogMetric(success ? SEND_SUCCESS : SEND_ERROR);
   LOG_IF(INFO, !success) << "ChromeToMobile send failed (" <<

[msw, 2012/09/24 17:23:20]

Also changed this.

                             source->GetResponseCode() << "): " << data;
 
   // Get the observer for this job submission response.
   base::WeakPtr<Observer> observer;
   RequestObserverMap::iterator i = request_observer_map_.find(source);
   if (i != request_observer_map_.end()) {
     observer = i->second;
     request_observer_map_.erase(i);
   }
 
   // Check if the observer is waiting on a second response (url or snapshot).
   for (RequestObserverMap::iterator other = request_observer_map_.begin();
        observer.get() && (other != request_observer_map_.end()); ++other) {
     if (other->second == observer) {
       // Delay reporting success until the second response is received.
       if (success)
         return;
 
       // Report failure below and ignore the second response.
       request_observer_map_.erase(other);
       break;
     }
   }
 
   if (observer.get())
     observer->OnSendComplete(success);
 }