compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java - Issue 10970024: Issue 5240. Using a non-type in a const object expression is an error, not a warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java

Issue 10970024: Issue 5240. Using a non-type in a const object expression is an error, not a warning (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java

diff --git a/compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java b/compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java

index 2d3ea6f73ed798becd1b5cdf0a64edddfda0cbcf..c326c6c0fa6ae7d0463611ae6944433d29d86565 100644

--- a/compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java

+++ b/compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java

@@ -248,7 +248,7 @@ public class ResolverCompilerTest extends CompilerTestCase {

"}"));

assertErrors(

libraryResult.getErrors(),

- errEx(ResolverErrorCode.NEW_EXPRESSION_NOT_CONSTRUCTOR, 5, 9, 5));

+ errEx(ResolverErrorCode.NEW_EXPRESSION_NOT_CONSTRUCTOR, 5, 11, 3));

DartUnit unit = libraryResult.getLibraryUnitResult().getUnits().iterator().next();

DartNewExpression newExpression = findExpression(unit, "new A.foo()");

ConstructorElement constructorElement = newExpression.getElement();