Issue 1096993003: Tighten assertions around StyleImage::computeIntrinsicDimensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1096993003: Tighten assertions around StyleImage::computeIntrinsicDimensions (Closed)

Created:
5 years, 8 months ago by davve

Modified:
5 years, 8 months ago

Reviewers:
fs

CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, jchaffraix+rendering

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Tighten assertions around StyleImage::computeIntrinsicDimensions By initializing to fixed we can assume not only that the intrinsic lengths should not be percentage but also that they should be fixed. BUG=479687 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194220

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	Source/core/layout/LayoutBoxModelObject.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096993003/1

5 years, 8 months ago (2015-04-22 13:47:03 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-22 14:56:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194220

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages