sync/engine/entity_tracker.h - Issue 1096983002: Update usages of std::map to use ScopedPtrMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/engine/entity_tracker.h

Issue 1096983002: Update usages of std::map to use ScopedPtrMap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@passwordmanager-scopedmemory

Patch Set: Rebase. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/engine/entity_tracker.h

diff --git a/sync/engine/entity_tracker.h b/sync/engine/entity_tracker.h

index e969ff97146fec5f791d2158e85e1de515186e35..f60af7dcaee79310a794ff7a7abce197c1672cf2 100644

--- a/sync/engine/entity_tracker.h

+++ b/sync/engine/entity_tracker.h

@@ -34,12 +34,13 @@ class SYNC_EXPORT EntityTracker {

~EntityTracker();

// Initialize a new entity based on an update response.

- static EntityTracker* FromServerUpdate(const std::string& id_string,

- const std::string& client_tag_hash,

- int64 version);

+ static scoped_ptr<EntityTracker> FromServerUpdate(

+ const std::string& id_string,

+ const std::string& client_tag_hash,

+ int64 version);

// Initialize a new entity based on a commit request.

- static EntityTracker* FromCommitRequest(

+ static scoped_ptr<EntityTracker> FromCommitRequest(

const std::string& id_string,

const std::string& client_tag_hash,

int64 sequence_number,

« no previous file with comments | « sync/engine/directory_update_handler_unittest.cc ('k') | sync/engine/entity_tracker.cc » ('j') | no next file with comments »