chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm - Issue 1096983002: Update usages of std::map to use ScopedPtrMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm

Issue 1096983002: Update usages of std::map to use ScopedPtrMap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@passwordmanager-scopedmemory

Patch Set: Rebase. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.cc ('k') | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_manage_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm

index 9204e8718582c2f1c21ed30605830fbb0def2769..84a8a53a82f67f3eab83b4ed71b37dfb47a4a9bd 100644

--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller_unittest.mm

@@ -4,6 +4,7 @@

#import "chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.h"

+#include "base/memory/scoped_ptr.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"

#import "chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_blacklist_view_controller.h"

@@ -75,12 +76,12 @@ TEST_F(ManagePasswordsBubbleBlacklistViewControllerTest,

TEST_F(ManagePasswordsBubbleBlacklistViewControllerTest,

ShouldDismissAndUnblacklistWhenUnblacklistClicked) {

// Unblacklisting requires passwords to exist for the site.

- autofill::PasswordForm form;

- form.username_value = base::ASCIIToUTF16("username");

- form.password_value = base::ASCIIToUTF16("password");

- form.blacklisted_by_user = true;

+ scoped_ptr<autofill::PasswordForm> form(new autofill::PasswordForm);

+ form->username_value = base::ASCIIToUTF16("username");

+ form->password_value = base::ASCIIToUTF16("password");

+ form->blacklisted_by_user = true;

autofill::PasswordFormMap map;

- map[base::ASCIIToUTF16("username")] = &form;

+ map.insert(base::ASCIIToUTF16("username"), form.Pass());

ui_controller()->OnBlacklistBlockedAutofill(map);

EXPECT_EQ(password_manager::ui::BLACKLIST_STATE, ui_controller()->state());