components/gcm_driver/instance_id/instance_id_impl.cc - Issue 1096983002: Update usages of std::map to use ScopedPtrMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/instance_id/instance_id_impl.cc

Issue 1096983002: Update usages of std::map to use ScopedPtrMap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@passwordmanager-scopedmemory

Patch Set: Fix Mac compile. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/dbus/gsm_sms_client.cc ('K') | « components/gcm_driver/instance_id/instance_id_driver.cc ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | ui/gfx/image/image.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/instance_id/instance_id_impl.cc

diff --git a/components/gcm_driver/instance_id/instance_id_impl.cc b/components/gcm_driver/instance_id/instance_id_impl.cc

index 3850eb19ee63136337bdbbe4aa1d719bfa429d05..66259b0619e65d6e84c61ad6693c685d3f7eac63 100644

--- a/components/gcm_driver/instance_id/instance_id_impl.cc

+++ b/components/gcm_driver/instance_id/instance_id_impl.cc

@@ -8,6 +8,7 @@

#include "base/base64.h"

#include "base/bind.h"

#include "base/logging.h"

+#include "base/memory/scoped_ptr.h"

#include "base/message_loop/message_loop.h"

#include "base/strings/string_number_conversions.h"

#include "components/gcm_driver/gcm_driver_desktop.h"

@@ -44,9 +45,9 @@ InstanceID::Result GCMClientResultToInstanceIDResult(

} // namespace

// static

-InstanceID* InstanceID::Create(const std::string& app_id,

- gcm::GCMDriver* gcm_driver) {

- return new InstanceIDImpl(app_id, gcm_driver);

+scoped_ptr<InstanceID> InstanceID::Create(const std::string& app_id,

+ gcm::GCMDriver* gcm_driver) {

+ return make_scoped_ptr(new InstanceIDImpl(app_id, gcm_driver));

}

InstanceIDImpl::InstanceIDImpl(const std::string& app_id,